8000 Add /estimateFee by voltrevo · Pull Request #161 · getwax/bls-wallet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Nov 5, 2023. It is now read-only.

Add /estimateFee #161

Merged
merged 10 commits into from
Mar 8, 2022
Merged

Add /estimateFee #161

merged 10 commits into from
Mar 8, 2022

Conversation

voltrevo
Copy link
Collaborator
@voltrevo voltrevo commented Mar 8, 2022

What is this PR doing?

Adds endpoint /estimateFee which takes a bundle and returns a response like this:

{
  "feeType": "ether",
  "feeDetected": "1",
  "feeRequired": "7700230000000000",
  "successes": [true]
}

How can these changes be manually tested?

Run the premerge script.

Does this PR resolve or contribute to any issues?

Resolves #154.

Checklist

  • I have manually tested these changes
  • Post a link to the PR in the group chat

Guidelines

  • If your PR is not ready, mark it as a draft
  • The resolve conversation button is for reviewers, not authors
    • (But add a 'done' comment or similar)

@github-actions github-actions bot added aggregator Aggregator backend related clients labels Mar 8, 2022
@voltrevo voltrevo marked this pull request as ready for review March 8, 2022 01:26
Base automatically changed from bw-152-modular-agg-logic to main March 8, 2022 05:48
@voltrevo voltrevo merged commit 961bb03 into main Mar 8, 2022
@voltrevo voltrevo deleted the bw-154-fee-endpoint branch March 8, 2022 05:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aggregator Aggregator backend related clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add http endpoint for fee information
2 participants
0