This repository was archived by the owner on Nov 5, 2023. It is now read-only.
Separate out AggregationStrategy #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacque006
approved these changes
Mar 7, 2022
Comment on lines
+1
to
+3
| export default function plus(a: number, b: number) { | ||
| return a + b; | ||
| } |
There was a problem hiding this comment.
Must've missed this last round, seems like overkill to have this separated out when something like (acc: number, numActions: number) => acc + numActions would do and be more descriptive.
There was a problem hiding this comment.
@jacque006 Hmm. As a reducer function I think plus is a bit simpler than a lambda that tries to add more context. Also, plus is used in two places so using lambdas would be a bit more verbose.
There was a problem hiding this comment.
Ah I missed the second usage, makes a little more sense now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Separates
AggregationStrategyfromBundleServiceso that all the logic for converting a known set of eligible bundles into a concrete aggregate bundle for submitting is in one place. (Basically just cut and paste half ofBundleServiceand then fix some imports.)This will make it easier eg to implement mev and other more complex strategies.
It also makes
BundleServicemore focused on the admin side of receiving bundles and deciding when to try to submit things on chain.How can these changes be manually tested?
Run the premerge script.
Does this PR resolve or contribute to any issues?
Resolves #152.
Checklist
Guidelines
resolve conversationbutton is for reviewers, not authors