8000 Upgrade Node.js to 22 by 1000ch · Pull Request #480 · getstation/desktop-app · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade Node.js to 22 #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Upgrade Node.js to 22 #480

wants to merge 2 commits into from

Conversation

1000ch
Copy link
@1000ch 1000ch commented Apr 27, 2025 •
edited
Loading

What is this PR

This PR upgrades Node.js used inside this app

How does it work

To use the maintained version of Node.js

Test instructions

Confirm tests pass and actual behaviors of built app

@1000ch 1000ch force-pushed the chore/use-nodejs-22 branch from b87cae4 to 58f3cf5 Compare April 27, 2025 13:59
@magne4000
Copy link
Member

LGTM. @viktor44 Do you see counter-indications for this to be merged?

@viktor44
Copy link
Collaborator
viktor44 commented May 2, 2025 •
edited
Loading

Current version uses Electron 27, hence Node 18 in runtime.
What's the point to build with Node 22? Is it safe?
I'm afraid it could cause problems especially with native dependencies

So IMO Node version should match with Electron version.

viktor44
viktor44 reviewed May 2, 2025
View reviewed changes
packages/app/package.json
@@ -187,7 +187,7 @@
"use-timeout": "^1.1.0",
"utility-types": "^3.7.0",
"uuid": "^3.3.3",
"windows-focus-assist": "patch:windows-focus-assist@npm%3A1.3.0#~/.yarn/patches/windows-focus-assist-npm-1.3.0-e02310a164.patch",
"windows-focus-assist": "^1.4.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should fix yarn release.
This change breaks it.

@magne4000
Copy link
Member

Current version uses Electron 27, hence Node 18 in runtime. What's the point to build with Node 22? Is it safe? I'm afraid it could cause problems especially with native dependencies

So IMO Node version should match with Electron version.

Your totally right, we shouldn't upgrade node version beyond what Electron actually supports.
I'm closing the PR for now.

@magne4000 magne4000 closed this May 3, 2025
@1000ch 1000ch deleted the chore/use-nodejs-22 branch May 3, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktor44 viktor44 viktor44 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1000ch @magne4000 @viktor44
0