8000 Change query processing wait time to make response quick by yoshiokatsuneo · Pull Request #7320 · getredash/redash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change query processing wait time to make response quick #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 7, 2025
Merged

Change query processing wait time to make response quick #7320

merged 6 commits into from
May 7, 2025
+41 −31

Conversation

yoshiokatsuneo
Copy link
Contributor

What type of PR is this?

  • Feature

Description

Before this PR, the query waiting interval is 0.5 seconds for up to 10 times, and 3 seconds after that.
So, the refreshStatus happens like: 0.5 / 1 / 1.5 / 2 / 2.5 / 3 / 3.5 / 4 / 4.5 / 5 / 8 / 11 / 14 (seconds) ...
There is large gap around ".. 4.5 / 5 / 8 ...".

This PR make the retrying interval gap more smooth by setting wait time to 1 second for retrying number between 11 and 50.

How is this tested?

  • Manually

@yoshiokatsuneo yoshiokatsuneo changed the title Change query processing wait time to make more response quick Change query processing wait time to make response quick Feb 10, 2025
@yoshiokatsuneo yoshiokatsuneo force-pushed the feat/change_query_processing_waittime branch from 60cd225 to 2b19010 Compare February 10, 2025 16:39
@yoshiokatsuneo
Copy link
Contributor Author

@arikfr

If possible, can you review this PR that practically just adds only 2 lines of code below and makes query much responsive.
(Another commit is just for fixing restyled error.)

          } else if (tryNumber <= 50) {
            waitTime = 1000;

3f7b779

arikfr
arikfr previously approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member
@arikfr arikfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arikfr arikfr enabled auto-merge (squash) April 30, 2025 07:23
auto-merge was automatically disabled April 30, 2025 11:10

Head branch was pushed to by a user without write access

@yoshiokatsuneo yoshiokatsuneo force-pushed the feat/change_query_processing_waittime branch from 68cabab to 2b19010 Compare April 30, 2025 11:10
@yoshiokatsuneo yoshiokatsuneo requested a review from arikfr April 30, 2025 14:35
@yoshiokatsuneo
Copy link
Contributor Author
yoshiokatsuneo commented Apr 30, 2025 •
edited
Loading

@arikfr
Because merging master caused a possibly flaky failed test, I re-pushed the merge commit and it makes your review stale.
(Now, all tests passed.)

Could you please re-approve and re-enable auto-merge ?

Thank you.

@yoshiokatsuneo
Copy link
Contributor Author

@arikfr Thank you!! And, can you merge it ?

@arikfr arikfr enabled auto-merge (squash) May 4, 2025 11:55
@arikfr arikfr merged commit 0900178 into getredash:master May 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr arikfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yoshiokatsuneo @arikfr
0