8000 Switch to mysqlclient from Python-MySQL by arikfr · Pull Request #4061 · getredash/redash · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Switch to mysqlclient from Python-MySQL #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2019
Merged

Switch to mysqlclient from Python-MySQL #4061

merged 1 commit into from
Aug 14, 2019

Conversation

arikfr
Copy link
Member
@arikfr arikfr commented Aug 12, 2019

What type of PR is this? (check all applicable)

  • Other

Description

  • Newer versions of Debian use MariaDB clients by default, which aren't compatible with Python-MySQL (it's unclear to me how the CI build passes - maybe it uses a cached redash/base:debian image?).
  • Python-MySQL isn't compatible with Python 3 and unmaintained, so needs to be replaced anyway.
  • As older version of memsql were using Python-MySQL I had to upgrade it as well. This version of memsql might not support Python 2, but as memsql isn't very popular in Redash, it seemed like a reasonable trade off.

@arikfr
Copy link
Member Author
arikfr commented Aug 12, 2019

@Jakdaw this doesn't affect your work in #3003, right?

@jezdez
Copy link
Member
jezdez commented Aug 13, 2019

@arikfr Yeah, we've also noticed tests passing, but it only fails when we tried building the Docker image to do a deploy. I assume that something in the Circle config does that, maybe the fact that the tests are run via docker-compose and the Docker images are built by the docker CLI? Have you not encountered this when deploying v8beta to the SASS?

jezdez
jezdez approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member
@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how #3003 may be incompatible to using mysqlclient but since this is blocking a v8 release (since the Docker image can't be built at the moment) I would err on the side of YOLO.

@Jakdaw
Copy link
Contributor
Jakdaw commented Aug 13, 2019

Can confirm no impact to the #3003 stuff from this.

@arikfr arikfr merged commit 934a145 into master Aug 14, 2019
@arikfr arikfr deleted the mysqlclient branch August 14, 2019 07:13
@weekly-digest weekly-digest bot mentioned this pull request Aug 19, 2019
Closed
@arikfr arikfr mentioned this pull request Sep 22, 2019
Closed
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Nov 14, 2019
@arikfr @harveyrendell
Switch to mysqlclient from Python-MySQL (getredash#4061)
5125e20
@luc-x41 luc-x41 mentioned this pull request Jul 29, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jezdez jezdez jezdez approved these changes

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arikfr @jezdez @Jakdaw @cclauss
0