feat(taxes): Add 8000 jobs to update EU Taxes #3390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d14606 to
0a11b7a
Compare
vincent-pochet
approved these changes
Mar 28, 2025
0a11b7a to
d05f702
Compare
annvelents
pushed a commit
that referenced
this pull request
Mar 31, 2025
## Context The EU Tax Management int 72CF egration generate taxes [from a json file](https://github.com/getlago/lago-api/blob/main/lib/lago_eu_vat/lago_eu_vat/eu_vat_rates.json). These taxes should be updated with we update the file. Related recent changes: #3356 ## Description The existing service already takes care of updating the existing taxes (see new spec added). This PR only adds jobs to run the update. When the file is updated, we should add a job to the migration or enqueue it from the console, or even make a rake console. What's your preference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The EU Tax Management integration generate taxes from a json file. These taxes should be updated with we update the file.
Related recent changes: #3356
Description
The existing service already takes care of updating the existing taxes (see new spec added). This PR only adds jobs to run the update.
When the file is updated, we should add a job to the migration or enqueue it from the console, or even make a rake console.
What's your preference?