Fix charge update service params #3384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcd208d to
eddc515
Compare
lovrocolic
approved these change
8000
s
Mar 26, 2025
vincent-pochet
approved these changes
Mar 27, 2025
eddc515 to
c1d3499
Compare
jdenquin
pushed a commit
that referenced
this pull request
Mar 27, 2025
## Context While executing the Charges::UpdateJob, we noticed that some data — specifically the properties key inside params — was being lost. This happened because payload_charge was passed to perform_later with symbol keys (:key), and ActiveJob/Sidekiq serializes job arguments using JSON, which does not handle deeply nested symbol keys properly. As a result, some nested data like properties was silently dropped during serialization. ## Description This PR ensures that payload_charge is passed to the job using .deep_stringify_keys, making the entire structure JSON-safe before enqueueing the job. Additionally, inside the Charges::UpdateService, params are converted back to symbolized keys using .to_h.deep_symbolize_keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While executing the Charges::UpdateJob, we noticed that some data — specifically the properties key inside params — was being lost. This happened because payload_charge was passed to perform_later with symbol keys (:key), and ActiveJob/Sidekiq serializes job arguments using JSON, which does not handle deeply nested symbol keys properly. As a result, some nested data like properties was silently dropped during serialization.
Description
This PR ensures that payload_charge is passed to the job using .deep_stringify_keys, making the entire structure JSON-safe before enqueueing the job. Additionally, inside the Charges::UpdateService, params are converted back to symbolized keys using .to_h.deep_symbolize_keys