[kernel] lifted functions fixes #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoy-jon
reviewed
Jul 4, 2025
| @@ -72,7 +72,7 @@ object `<`: | |||
| val value = v.unsafeGet | |||
| Safepoint.handle(value)( | |||
| suspend = mapLoop(value), | |||
| continue = f(value) | |||
| continue = f(value): B < S2 | |||
There was a problem hiding this comment.
@fwbrasil 👏 👏 that's an amazing catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@ahoy-jon found a couple of issues with lifted functions. Due to the definition of the implicit conversions being in the same scope as the definition of
opaque type <, the compiler doesn't introduce aliftconversion, which creates issues with nested computations in generic scopes. Additionally, the compiler is having issues with inlining of pure functions in generic contexts that requires an explicit type annotation.Solution
Introduce the missing
liftcalls in the function conversions and add explicit type annotations in methods that take functions.