8000 fix: don't cache the assets base url by goenning · Pull Request #669 · getfider/fider · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: don't cache the assets base url #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2018
Merged

fix: don't cache the assets base url #669

merged 2 commits into from
Dec 4, 2018

Conversation

goenning
Copy link
Member
@goenning goenning commented Dec 4, 2018

Issue: closes #666

@codecov-io
Copy link
codecov-io commented Dec 4, 2018 •
edited
Loading

Codecov Report

Merging #669 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
- Coverage   73.57%   73.49%   -0.08%     
==========================================
  Files         105      105              
  Lines        6773     6772       -1     
==========================================
- Hits         4983     4977       -6     
- Misses       1424     1429       +5     
  Partials      366      366
Impacted Files Coverage Δ
app/pkg/web/renderer.go 84.96% <100%> (-0.13%) ⬇️
app/pkg/log/database/logger.go 66.67% <0%> (-3.85%) ⬇️
app/pkg/log/console/logger.go 44.44% <0%> (-3.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ddbb2...62f34f6. Read the comment docs.

@goenning goenning merged commit 0290a84 into master Dec 4, 2018
@goenning goenning mentioned this pull request Dec 5, 2018
Merged
@goenning goenning deleted the fix-666 branch December 21, 2018 18:46
goenning added a commit that referenced this pull request Dec 21, 2018
@goenning
fix: don't cache the assets base url (#669)
b160715
goenning added a commit that referenced this pull request Dec 21, 2018
@goenning
backport: PR #669 to 0.17.1
9bdf8d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS load balancer appears to set the asset url
2 participants
@goenning @codecov-io
0