implement html extration feature #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use `(*regexp.Regexp).MatchString` instead of
`(*regexp.Regexp).Match([]byte(...))` when matching string to avoid
unnecessary `[]byte` conversions and reduce allocations.
Example benchmark:
func BenchmarkMatch(b *testing.B) {
for i := 0; i < b.N; i++ {
if match := envVarNameRegexp.Match([]byte("FOO_BAR")); !match {
b.Fail()
}
}
}
func BenchmarkMatchString(b *testing.B) {
for i := 0; i < b.N; i++ {
if match := envVarNameRegexp.MatchString("FOO_BAR"); !match {
b.Fail()
}
}
}
goos: linux
goarch: amd64
pkg: go.ddosify.com/ddosify/core/types
cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics
BenchmarkMatch-16 4542174 277.2 ns/op 8 B/op 1 allocs/op
BenchmarkMatchString-16 7210927 172.1 ns/op 0 B/op 0 allocs/op
PASS
ok go.ddosify.com/ddosify/core/types 3.908s
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Avoid allocations with `(*regexp.Regexp).MatchString`
html-query-feature
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 81.77% 81.62% -0.15%
==========================================
Files 37 38 +1
Lines 5195 5241 +46
==========================================
+ Hits 4248 4278 +30
- Misses 766 778 +12
- Partials 181 185 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.