8000 fix: fix diff mode select by Hypnosphi · Pull Request #634 · gemini-testing/html-reporter · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix diff mode select #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix: fix diff mode select #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
10000
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/static/components/controls/common-controls.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class ControlButtons extends Component {
size='m'
label="Diff mode"
value={view.diffMode}
handler={actions.changeDiffMode}
handler={diffModeId => actions.setDiffMode({diffModeId})}
options = {Object.values(DiffModes).map((dm) => {
return {value: dm.id, content: dm.title};
})}
Expand Down
2 changes: 1 addition & 1 deletion lib/static/components/modals/screenshot-accepter/header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export default class ScreenshotAccepterHeader extends Component {
size="m"
label="Diff mode"
value={view.diffMode}
handler={actions.changeDiffMode}
handler={diffModeId => actions.setDiffMode({diffModeId})}
options = {Object.values(DiffModes).map((dm) => {
return {value: dm.id, content: dm.title};
})}
Expand Down
2 changes: 1 addition & 1 deletion test/unit/lib/static/components/modals/screenshot-accepter/header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe('<ScreenshotAccepterHeader/>', () => {

const DEFAULT_PROPS = {
view: {diffMode: DiffModes.THREE_UP_SCALED},
actions: {changeDiffMode: sinon.stub().returns({type: 'some-type'})},
actions: {setDiffMode: sinon.stub().returns({type: 'some-type'})},
totalImages: 2,
acceptedImages: 0,
images: [{
Expand Down
0