[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOT-7641] Support the "Sweep" parameter in the geostationary projections #4896

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajhoffma
Copy link
@ajhoffma ajhoffma commented Aug 30, 2024

A fix to the geostationary projection in geotools to allow setting the sweep
axis as appropriate for GOES. The WKT parser only allows parameters
that can be parsed as doubles so I didn't add the sweep_axis as a parameter
with values x,y (which doesn't seem to be done anywhere anyway). We could fix
that, but it's a larger change. Instead, I added a sweep parameter that's
either a 0 (x) or a 1 (y).

All the math is copied over from PROJ of course, as it was before, but now it's
copied from a newer version of PROJ (5.2 instead of 4.9).

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • There is an issue in GeoTools Jira (except for changes not visible to end users).
  • Commit message(s) must be in the form [GEOT-XYZW] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • The commit targets a single objective (if multiple focuses cannot be avoided, each one is in its own commit, and has a separate ticket describing it).

@mprins mprins mentioned this pull request Sep 3, 2024
11 tasks
@ajhoffma ajhoffma changed the title Main [GEOT-7641] Support the "Sweep" parameter in the geostationary projections Sep 3, 2024
Copy link
Member
@mprins mprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure your code is valid java and at least compiles

@ajhoffma
Copy link
Author
ajhoffma commented Sep 3, 2024

Still a draft and learning how to use Github, my company uses a different VCS so it's taking me longer just to figure out how to do simple commit merges and stuff here.

@mprins
Copy link
Member
mprins commented Sep 5, 2024

You only need to follow the steps outlined in https://docs.geotools.org/latest/developer/procedures/contribute.html

A fix to the geostationary projection in geotools to allow setting the sweep
axis as appropriate for GOES. The WKT parser only allows parameters
that can be parsed as doubles so I didn't add the sweep_axis as a parameter
with values x,y (which doesn't seem to be done anywhere anyway). We could fix
that, but it's a larger change. Instead, I added a sweep parameter that's
either a 0 (x) or a 1 (y).

All the math is copied over from PROJ of course, as it was before, but now it's
copied from a newer version of PROJ (5.2 instead of 4.9).
@ajhoffma
Copy link
Author

please make sure your code is valid java and at least compiles

Done, commits were in a weird state for some reason.

@ajhoffma ajhoffma requested a review from mprins November 21, 2024 21:59
@aaime
Copy link
Member
aaime commented Dec 2, 2024

Looks like it wasn't build by maven before issuing the PR (among other things, it auto-reformats to the required style):

Error:  Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.20.0:check (default) on project gt-referencing: The following files had format violations:
Error:      src/main/java/org/geotools/referencing/operation/projection/GeostationarySatellite.java
Error:          @@ -21,8 +21,6 @@
Error:           
Error:           import·java.awt.geom.Point2D;
Error:           import·java.util.Collection;
Error:          -import·java.util.Objects;
Error:          -
Error:           import·org.geotools.api.geometry.Bounds;
Error:           import·org.geotools.api.parameter.GeneralParameterDescriptor;
Error:           import·org.geotools.api.parameter.ParameterDescriptor;
Error:          @@ -114,6 +112,7 @@
Error:           ····/**
Error:           ·····*·Transforms·these·coordinates·to·the·initialization·vector·for·calculating·the·satellite·view
Error:           ·····*·vector.
Error:          +·····*
Error:           ·····*·@param·x·The·X·coordinate·on·Earth.
Error:           ·····*·@param·y·The·Y·coordinate·on·Earth.
Error:           ·····*·@param·yz·A·point·whose·location·is·set·to·the·Y·and·Z·initializers·of·the·view·vector.
Error:  Run 'mvn spotless:apply' to fix these violations.
Error:  -> [Help 1]

Copy link
Member
@aaime aaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, please make sure the QA build gives you a green (it's possible to run the QA machinery on the local computer, the PR checklist has a link to docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants