-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEOT-7641] Support the "Sweep" parameter in the geostationary projections #4896
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please make sure your code is valid java and at least compiles
Still a draft and learning how to use Github, my company uses a different VCS so it's taking me longer just to figure out how to do simple commit merges and stuff here. |
You only need to follow the steps outlined in https://docs.geotools.org/latest/developer/procedures/contribute.html |
3920034
to
4207f71
Compare
A fix to the geostationary projection in geotools to allow setting the sweep axis as appropriate for GOES. The WKT parser only allows parameters that can be parsed as doubles so I didn't add the sweep_axis as a parameter with values x,y (which doesn't seem to be done anywhere anyway). We could fix that, but it's a larger change. Instead, I added a sweep parameter that's either a 0 (x) or a 1 (y). All the math is copied over from PROJ of course, as it was before, but now it's copied from a newer version of PROJ (5.2 instead of 4.9).
Done, commits were in a weird state for some reason. |
Looks like it wasn't build by maven before issuing the PR (among other things, it auto-reformats to the required style):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, please make sure the QA build gives you a green (it's possible to run the QA machinery on the local computer, the PR checklist has a link to docs)
A fix to the geostationary projection in geotools to allow setting the sweep
axis as appropriate for GOES. The WKT parser only allows parameters
that can be parsed as doubles so I didn't add the sweep_axis as a parameter
with values x,y (which doesn't seem to be done anywhere anyway). We could fix
that, but it's a larger change. Instead, I added a sweep parameter that's
either a 0 (x) or a 1 (y).
All the math is copied over from PROJ of course, as it was before, but now it's
copied from a newer version of PROJ (5.2 instead of 4.9).
Checklist
main
branch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOT-XYZW] Title of the Jira ticket
.