8000 Add MapTiler by chilfing · Pull Request #397 · geopy/geopy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add MapTiler #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Add MapTiler #397

wants to merge 0 commits into from

Conversation

chilfing
Copy link
Contributor

No description provided.

@chilfing chilfing force-pushed the master branch 2 times, most recently from 4a7a4f0 to a874e8e Compare February 19, 2020 13:57
@chilfing chilfing closed this Feb 24, 2020
@chilfing chilfing reopened this Feb 24, 2020
@sfkeller
Copy link
sfkeller commented Mar 3, 2020 •
edited
Loading

@KostyaEsmukov KostyaEsmukov added this to the 1.22 milestone Mar 9, 2020
KostyaEsmukov
KostyaEsmukov requested changes Mar 9, 2020
View reviewed changes
Copy link
Member
@KostyaEsmukov KostyaEsmukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for late review.

This is of very good quality, thank you! I left some minor comments, besides that, I think this is good to go!

I'll try to register an account on the service later this week to add their API token to CI.

@chilfing chilfing closed this Mar 16, 2020
@chilfing chilfing reopened this Mar 16, 2020
@klokan
Copy link
klokan commented Mar 16, 2020 •
edited
Loading

Very happy to see the implementation of the geocoder in geopy. Thanks!

Documentation is available at https://cloud.maptiler.com/geocoding/.
You need to create a FREE account to use the service.

@chilfing chilfing requested a review from KostyaEsmukov March 18, 2020 09:35
@sfkeller
Copy link
sfkeller commented Apr 6, 2020 •
edited
Loading

@KostyaEsmukov Did you see the review request?

@KostyaEsmukov
Copy link
Member

Whoops, didn't mean to close it.

Resolved conflicts and merged as ad31b19. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KostyaEsmukov KostyaEsmukov Awaiting requested review from KostyaEsmukov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@chilfing @sfkeller @klokan @KostyaEsmukov
0