Added ability to use local ArcGIS server #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geopy/geocoders/arcgis.py
Outdated
| :param str domain: Domain where the target ArcGIS service | ||
| is hosted. | ||
|
|
||
| :param str auth_domain: Domain where the target ArcGIS auth service |
There was a problem hiding this comment.
Order of params in the docstring should match the order of arguments of the function.
Either function args or the params in the doc should be swapped.
There was a problem hiding this comment.
Also I would suggest to add to the auth_domain doc a clarification that this parameter will be used only when authentication is enabled (i.e. username, password or referer are set), otherwise it might be confusing what to put here if a local geocoder server does not have a corresponding auth server.
|
Linking #192 — the original issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.