Add restricting results via bounded parameter in Nominatim #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostyaEsmukov
requested changes
Mar 15, 2018
|
I added the bounded parameter in a similar way and I get None as a result of geocoding. any updates on this issue? |
|
well I don't think that the None that I am getting is because of that since the view_box that I use is for a city and when I include the name of the city in the query (but without view_box) I will get relevant results with coordinates inside the view_box. |
|
That is interesting. But anyway, this looks like a peculiarity in Nominatim's behavior, which doesn't seem to be related to geopy itself (and this PR in particular). I would say that your #307 issue is a better venue for that (if it's still a problem). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewbox area is preferred area to find search results.
The goal of adding bounded parameter is guaranteed restricting results to the bounding box.
For example
[query without bounded](http://nominatim.openstreetmap.org/search.php?q=строитель томск&viewbox=84.719353,56.588456,85.296822,56.437293)
geolocator = Nominatim(format_string='%s,Томск', view_box=('84.719353','56.588456','85.296822','56.437293')) - I want to get coords from Tomsk/Tomsk district etc excluding cities/villages south of the Tomsk
so [query with bounded](http://nominatim.openstreetmap.org/search.php?q=строитель томск&viewbox=84.719353,56.588456,85.296822,56.437293&bounded=1) is what I need
geolocator = Nominatim(format_string='%s,Томск', view_box=('84.719353','56.588456','85.296822','56.437293'), bounded=True)