Additional parameters for Bing reverse method #166
Conversation
|
Would be nice if someone could check this pull-request. I would like to see this change in the upstream code. |
|
Is there any change to get this pull request accepted? Is this project still active? At the moment there are 27 pull request open. This is one of them and it's open since Nov 2015! |
Optional parameters that influence the form of the response such as culture (sets the language of the response) or whether to include the two-letter ISO code of the country.
|
I added some tests for the two new parameters. But it seems that there are no API keys configured in the CI environment. On my local machine with my Bing API key the tests run fine |
|
The reason why API key is missing in CI is because Travis doesn't expose environment variables to forks due to security considerations. I haven't found a decent solution for this yet, unfortunately. But I ran the tests locally and I confirm that they have passed. LGTM, merging. Thank you! |
Optional parameters that influence the form of
the response such as culture (sets the language
of the response) or whether to include the
neighborhood or the two-letter ISO code of the
country.