8000 Handle rexml dependency in Ruby 3.0 by trevorturk · Pull Request #250 · geokit/geokit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Handle rexml dependency in Ruby 3.0 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 26, 2021
Merged

Handle rexml dependency in Ruby 3.0 #250

merged 8 commits into from
Jul 26, 2021

Conversation

trevorturk
Copy link
Contributor
@trevorturk trevorturk commented Jun 14, 2021 •
edited
Loading

Starting in Ruby 3.0, many gems are now "bundled gems" which are not required by default. [1] [2]

After trying a few things (details) and chatting with @olleolleolle, I adjusted this PR to only require rexml if we're parsing xml, and then rescue the possible LoadError with a logger.error message before re-raising. The simplest fix, really, is for Ruby 3.0 users to add rexml to their Gemfile so this should point the way.

@coveralls
Copy link
coveralls commented Jun 14, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 96.321% when pulling b6eae5f on trevorturk:rexml into 130ac22 on geokit:master.

@trevorturk trevorturk changed the title Add rexml dependency for Ruby 3.0 Handle rexml dependency in Ruby 3.0 Jun 14, 2021
olleolleolle
olleolleolle approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor
@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a quite tight and informative change!

@dsantosmerino
Copy link
Member

Thanks, @trevorturk, not only for your contribution here but also for all the provided context. I think we can use this approach at the moment and see how the gem evolves, dropping the support to old Ruby versions soon.

@dsantosmerino dsantosmerino merged commit e9e4027 into geokit:master Jul 26, 2021
@trevorturk trevorturk mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@dsantosmerino dsantosmerino dsantosmerino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trevorturk @coveralls @dsantosmerino @olleolleolle
0