10000 Fix merging of function coverage by Spacetown · Pull Request #925 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix merging of function coverage #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2024

Conversation

Spacetown
Copy link
Member

If functions were merged into separate lines the block coverage (percentage) was summarised for a line. The same for the excluded flag (bool)

Spacetown added 3 commits May 5, 2024 11:11
- The type annotation for the blocks was wrong.
- If separate functions where merged the blocks (percentage) and the
  excluded (bool) where summarized.
@Spacetown Spacetown added this to the Upcoming release milestone May 5, 2024
Copy link
codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 94.65%. Comparing base (f5d43e5) to head (92cd899).

Files Patch % Lines
gcovr/merging.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #925      +/-   ##
==========================================
- Coverage   94.70%   94.65%   -0.05%     
==========================================
  Files          50       50              
  Lines        3912     3913       +1     
  Branches      824      825       +1     
==========================================
- Hits         3705     3704       -1     
- Misses        129      130       +1     
- Partials       78       79       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spacetown Spacetown merged commit 3e53c61 into gcovr:main May 5, 2024
32 of 62 checks passed
@Spacetown Spacetown deleted the fix_merging_of_function_coverage branch May 5, 2024 11:19
@Spacetown Spacetown removed this from the Upcoming release milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0