8000 Bugfix: Erroneous deprecation warning by Tsche · Pull Request #912 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugfix: Erroneous deprecation warning #912

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 4, 2024
Merged

Bugfix: Erroneous deprecation warning #912

merged 4 commits into from
Apr 4, 2024

Conversation

Tsche
Copy link
Contributor
@Tsche Tsche commented Apr 2, 2024 •
edited by Spacetown
Loading

Fixes #909

@Spacetown
Copy link
Member

Thanks for fixing this. Please can you add the issue to the fixes in the changelog?

@Spacetown Spacetown self-requested a review April 3, 2024 19:15
Spacetown
Spacetown approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member
@Spacetown Spacetown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgfm

@Spacetown Spacetown added Type: Bug Docs related to the documentation or website labels Apr 3, 2024
@Spacetown Spacetown added this to the Upcoming release milestone Apr 3, 2024
@Tsche
Copy link
Contributor Author
Tsche commented Apr 3, 2024

Oh, the changelog-check is failing because I used the issue ID (#909) rather than this PR's ID. Shall I change that?

@Spacetown
Copy link
Member

Yes, please.

@codecov Codecov
Copy link
codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project cov 98E9 erage is 94.52%. Comparing base (af282ec) to head (533c536).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #912      +/-   ##
==========================================
- Coverage   94.57%   94.52%   -0.06%     
==========================================
  Files          50       50              
  Lines        3888     3888              
  Branches      816      816              
==========================================
- Hits         3677     3675       -2     
- Misses        131      133       +2     
  Partials       80       80

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Spacetown Spacetown merged commit e8c5fbf into gcovr:main Apr 4, 2024
@Spacetown Spacetown removed this from the Upcoming release milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spacetown Spacetown Spacetown approved these changes

Assignees
No one assigned
Labels
Docs related to the documentation or website Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Erroneous deprecation warning
2 participants
@Tsche @Spacetown
0