Support of toml configuration #881
Conversation
|
I will look into it in more detail later in the week, but 2 quick unrelated notes:
For the code itself something feels off with how |
There was a problem hiding this comment.
This is a big/important feature, and that makes me a bit nervous.
I'm on board with the main ideas of this PR:
- support a
gcovr.tomlfile - handle multi-value options by flattening a toml list into one ConfigEntry per element
I am less certain about the other stuff – multiple configurations, pyproject.toml support. See the following comments for detailed discussion.
This reverts commit fdc0a1b.
No problem.
I won't do this in the near future because in my company we use SCM Clearcase and the path resolution is not working there. I've already provided a patch for os.path to work in Clearcase but need to raise a PR for path lib to ignore the same errors in path resolution on Windows as os.path is doing.
dict supports [] since 3.9 but we still support 3.8.
This is changed with the next push as suggested by @latk:
|
- In pyproject.toml `tool.gcovr` is used. - In gcovr.toml no section is used.
10cfafd to
46c6cf5
Compare
The config parsing is done with iterators and the needs to be handled while the file is opened (inside the `with` statement).
46c6cf5 to
27273fb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 54 54
Lines 4544 4566 +22
Branches 893 904 +11
=======================================
+ Hits 4332 4353 +21
Misses 130 130
- Partials 82 83 +1 ☔ View full report in Codecov by Sentry. |
|
@LecrisUT Any updates here? |
This PR adds initial support for a TOML configuration. Following configuration files are searched in the root directory, the first one which is found is used:
If a TOML file is found the section
gcovris searched which can also be a list. If no section is found the file is ignored.I prefer first to do a review on the code and if this is done I'll start with the documentation.
Closes #875