8000 Prevent Chrome from crashing on large function lists. by macetw · Pull Request #858 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prevent Chrome from crashing on large function lists. #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 25, 2024
Merged

Prevent Chrome from crashing on large function lists. #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6810733
Issue#857: Introduced function table breaks to prevent browser crash
macetwatargo Dec 1, 2023
4daaf50
Align new lines
Spacetown Dec 1, 2023
da7bf1a
Replace check for first with loop.index0
Spacetown Dec 1, 2023
bb81e87
Update CHANGELOG.
Spacetown Dec 1, 2023
d533518
Removed the table-splitting for source-page, That's not practical, an…
macetwatargo Dec 4, 2023
9e6539a
Merge remote-tracking branch 'upstream/main' into break_function_list…
Spacetown Dec 14, 2023
c94adcd
Merge commit 'ca5b70d036bd9d29a5dbc45e16265c0977455e99' into break_fu…
Spacetown Jan 22, 2024
0cb5a9f
Apply suggestion for batching the list of function in template
Spacetown Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Load 8000 ing
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@ New features and notable changes:
- Use different color for partial covered lines in HTML report. (:issue:`839`)
- Add support to generate LCOV info files. (:issue:`830`)
- Add support for FIPS enabled OS when used with Python 3.9. (:issue:`850`)
- Reduce file size for detailed HTML reports by using CSS to link the function lists. (:issue:`840`)
- Ignore all negative hits if :option:`--gcov-ignore-parse-errors` is used. (:issue:`852`)
- Reduce file size for detailed HTML reports by merging columns the function lists. (:issue:`840`)
- Use literal options for sorting and TXT metric. (:issue:`867`)

- The :option:`-b`, :option:`--txt-branches` and :option:`--branches` are deprecated, use :option:`--txt-metric` instead.
Expand All @@ -49,6 +49,7 @@ New features and notable changes:
- The :option:`--sort-uncovered` and :option:`--sort-percentage` are deprecated, use :option:`--sort` instead.
The reason for this is that only one sorting order shall be selectable and and an enumeration is easier to handle
than several flags.
- Split list of functions into tables with maximum 10000 rows to fix rendering issues. (:issue:`858`)

Bug fixes and small improvements:

Expand Down
6 changes: 4 additions & 2 deletions gcovr/formats/html/default/functions_page.content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{# -*- engine: jinja -*- #}
{% for function_batch in all_functions | batch(10000) %}
<table class="listOfFunctions">
<tr>
<th>Function (File:Line)</th>
<th>Call count</th>
<th>Block coverage</th>
</tr>
{% for entry in all_functions %}
{% for entry in function_batch %}
<tr>
{#- #}<td><a href="{{ entry['html_filename'] }}#l{{ entry['line'] }}">{{ entry["name"] }} ({{ entry["filename"] }}:{{ entry["line"] }})</a></td>
{#- #}<td>
Expand All @@ -19,5 +20,6 @@
{#- #}<td>{{ entry["blocks"] }}%</td>
{#- -#}
</tr>
{% endfor %}
{% endfor %}
</table>
{% endfor %}
14 changes: 8 additions & 6 deletions gcovr/formats/html/github/functions_page.content.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
{# -*- engine: jinja -*- #}
{% for function_batch in all_functions | batch(10000) %}
<table class="m-3 text-mono text-small listOfFunctions" style="width:100%;">
<tr class="text-left">
<th>Function (File:Line)</th>
<th>Call count</th>
<th>Block coverage</th>
<tr class="text-left">
<th>Function (File:Line)</th>
<th>Call count</th>
<th>Block coverage</th>
</tr>
{% for entry in all_functions %}
{% for entry in function_batch %}
<tr>
{#- #}<td><a href="{{ entry['html_filename'] }}#l{{ entry['line'] }}">{{ entry["name"] }} ({{ entry["filename"] }}:{{ entry["line"] }})</a></td>
{#- #}<td>
Expand All @@ -19,5 +20,6 @@
{#- #}<td>{{ entry["blocks"] }}%</td>
{#- -#}
</tr>
{% endfor %}
{% endfor %}
</table>
{% endfor %}
0