Setup test case for coexisting object directories #832
Conversation
|
Thanks for the test. Please can you use the extension |
|
My bad! Twenty years of habits ;) |
|
Please add a entry in the CHANGELOG.rst. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 54 54
Lines 4483 4483
Branches 878 878
=======================================
Hits 4273 4273
Misses 127 127
Partials 83 83 ☔ View full report in Codecov by Sentry. |
00391fc to
01d6c43
Compare
There was a problem hiding this comment.
I thinkl gcovr isn't executed in parallel since the -j option is missing when calling make. I`ve adapted the test environment on the branch https://github.com/Spacetown/gcovr/tree/feature/coexisting_object_directories I've modified your tests and the tests coexisting_object_directories-from_build_dir-without_search_dir and coexisting_object_directories-from_root_dir-without_object_dir are failing because of concurency.
Please have a look.
|
Thanks for upgrading the test environment, this will avoid the dirty call I previously had to do in the makefiles themselves 😞 The concurrency issue is now fixed using some dedicated rules ( Now (well, at least on my local tests), only the expected tests (the |
I don't get what this additional rule is fixing. The result should be the same. I need to check this the next days. |
|
The additional rule doesn't change anything. If I understand you correct the tests "without" should fail because of the parallel execution. This we can't test here. For the test |
2c5063e to
e1c6f55
Compare
1d0f9f4 to
613f42a
Compare
There was a problem hiding this comment.
I've updated the tests to get them green.
@oleurodecision Please can you check again from your side?
|
@oleurodecision Have you already checked it? |
…object_directories
|
@oleurodecision I'm waiting for your response to merge this. |
|
Thanks for waiting, and sorry for the late, my wife has been (and is still) very illed, and I am facing lack of time to seriously work on the subject. For what I quickly reviewed, it seems ok, so let's go ! Once again, thanks for the tool and the time spent on it. |
The PR aims to present a basic setup for testing issue(s) related to coexisting object directories.
The candidate_tests.bash script contains several valid or failing gcovr call variants (parallelised or non-parallelised calls).
Related to #756.
Closes #756.
Please ask for any piece of information needed on the subject.