10000 📚🩹 Fix wrong command in 'How to create a standalone application' docs by s-weigand · Pull Request #792 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

📚🩹 Fix wrong command in 'How to create a standalone application' docs #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 3, 2023

Conversation

s-weigand
Copy link
Contributor

Thanks for adding the bundling option, this makes it a lot easier to add into docker images without the need to add python itself.

There is a small bug in the docs where the command is python3 -m nox --session build_app but should be python3 -m nox --session bundle_app.

def bundle_app(session: nox.Session) -> None:

@Spacetown
Copy link
Member

Thanks for fixing this. Pleas can you add e entry in the changeling and add yourself to the contributors?

@Spacetown Spacetown added Type: Bug Docs related to the documentation or website labels Jun 3, 2023
@Spacetown Spacetown added this to the Upcoming release milestone Jun 3, 2023
Copy link
Member
@Spacetown Spacetown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the authors file (Firstname Lastname) and replaced single quotes with RST inline verbatim in changelog.

@codecov
Copy link
codecov bot commented Jun 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d8871de) 95.58% compared to head (56013ba) 95.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #792   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          40       40           
  Lines        4028     4028           
  Branches      789      789           
=======================================
  Hits         3850     3850           
  Misses        101      101           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@s-weigand
Copy link
Contributor Author

@Spacetown Thanks for fixing that.
Also looks like cryptography had a new release 2 days back , guess that is why the CI fails

@Spacetown Spacetown merged commit d31273a into gcovr:master Jun 3, 2023
@s-weigand s-weigand deleted the fix-bundle-docs branch June 3, 2023 20:23
@Spacetown Spacetown removed this from the Upcoming release milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs related to the documentation or website Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0