8000 Ignore exit code 6 from gcov execution by Spacetown · Pull Request #781 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ignore exit code 6 from gcov execution #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Spacetown
Copy link
Member

This exit code was introduced by gcc-mirror/gcc@815f15d which adds proper exit codes to gcov.

It was released first with gcc-12 and stops gcovr from working since we do not ignore the exit code from gcov (#653) and rely on the printed error message here.

The regex for the error message is also extended to catch the errors printed by clang.

Closes #775.

@Spacetown Spacetown added this to the Upcoming release milestone May 7, 2023
@codecov
Copy link
codecov bot commented May 7, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: +0.03 🎉

Comparison is base (c0c49b9) 95.54% compared to head (887fb13) 95.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #781      +/-   ##
==========================================
+ Coverage   95.54%   95.57%   +0.03%     
==========================================
  Files          40       40              
  Lines        4021     4026       +5     
  Branches      786      788       +2     
==========================================
+ Hits         3842     3848       +6     
  Misses        101      101              
+ Partials       78       77       -1     
Impacted Files Coverage Δ
gcovr/tests/test_gcovr.py 98.81% <ø> (ø)
gcovr/formats/gcov/read.py 81.99% <80.00%> (+0.62%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Spacetown Spacetown marked this pull request as draft May 7, 2023 16:44
…ocess

  File "/gcovr/gcovr/formats/gcov/read.py", line 563, in __get_gcov_process
    **kwargs,
  File "/usr/lib/python3.7/subprocess.py", line 800, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.7/subprocess.py", line 1551, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
PermissionError: [Errno 13] Permission denied: '/gcovr/gcovr/tests/not_writable_source_dir/src'
@Spacetown Spacetown marked this pull request as ready for review May 7, 2023 17:49
@Spacetown Spacetown merged commit d8871de into gcovr:master May 24, 2023
@Spacetown Spacetown deleted the use_writable_directory_for_gcov_execution branch May 24, 2023 20:43
@Spacetown Spacetown removed this from the Upcoming release milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to work if source directory is read only
1 participant
0