Add thread information to logging #752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankwiles
pushed a commit
to revsys/gcovr
that referenced
this pull request
Apr 4, 2023
* Add thread to log messages if multithreading is active.
Spacetown
added a commit
that referenced
this pull request
Aug 14, 2023
* Add --template-dir option to README * Add to other file * Add --template-dir argument * Fix typo * Finish --template-dir option Pass options down to `templates()` everywhere it's called. Change which jinja2 loader is used depending on existence of the argument. * Add useful docs for --template-dir * Add thread information to logging (#752) * Add thread to log messages if multithreading is active. * Fix nested report if only one directory in root is present. (#750) - Add comments and to collapse code and remove not needed endless loop. The loop is always executed only once because because the first statement in the block isn't changed in a second iteration. - Collapse also the data in the root. - Use `pop(key)` instead of copying the whole dict ignoring the value. - Fix evaluating of common path in nested HTML report. The root_filter wasn't applied to the root directory in HTML report since there is no trailing path separator at the end. Now the directories always have a trailing path separator which is removed in the report generation. To get the common path part the root directory is excluded. - Replace recursive generation of directory stats with a loop. - Use a object instead of a dataclass and remove the recursive function and the tests for it. - Improve detection of root directory. * Add interface to writer modules (#755) * Move formats to sub directories. * Move function print_reports from __main__.py to writer/__init__.py. * Write global logger uppercase because it's constant. * Move gcov data handling to a own format handler * Use constants for the exit code. * Add prefix of format to each option. * Only forward the options of the format and some generic options to the handler. * Add one config key for each long option. * Add --html-template-dir argument * Finish --html-template-dir option Pass options down to `templates()` everywhere it's called. Change which jinja2 loader is used depending on existence of the argument. * Resolve merge issue and refactor - Refactor based on suggestion * Fix merge and refactor to new output layout - Refactors code to use new `gcovr/formats/` layout - Renames option to `--html-template-dir` - Fixes merge artifacts I created on accident * Add Frank Wiles to AUTHORS.txt * Use Jinja2 ChoiceLoader This allows the user to only have to override the certain templates they wish to adjust and it will fall through to using the included ones for any template names the user has not overriden in `--html-template-dir` * Update documentation to reflect ChoiceLoader * Fix docs typo * Fix README typo * Remove merge mistake * Update CHANGELOG * Add --html-template-dir test * Change what we're testing on --html-template-dir * Fix test again * Improve template-dir option docs * Improve template-dir docs * Add tests to ensure templates are overridden - Ensure the two we override are indeed overidden - Ensure we fall through to default templates if not * Remove debugging print * Add template test * Forgot to save Makefile change * Update failing HTML/CSS comparison * Update gcovr/tests/test_html_generator.py Co-authored-by: Michael Förderer <michael.foerderer@gmx.de> * Fix linting issue * Remove test that behaves oddly in CI * Fix CI run * Update documentation * Update reference data * Fix documentation error --------- Co-authored-by: Michael Förderer <michael.foerderer@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without threads the logging isn't changed. If more than one thread is used the message looks like this:
Closes #751