8000 Fix problem in decision parser if case is not on a single line with the break statement. by Spacetown · Pull Request #738 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix problem in decision parser if case is not on a single line with the break statement. #738

New issue
Jump to bottom
Merged
merged 9 commits into from
Mar 7, 2023
Merged

Fix problem in decision parser if case is not on a single line with the break statement. #738

merged 9 commits into from
Mar 7, 2023

Conversation

Spacetown
Copy link
Member

Only single line cases are detected by the current decision parser. This PR extends the decision parser to detect also multi line case statements as suggested in #665 (comment).

Closes #665

@Spacetown Spacetown added this to the 6.0 milestone Feb 27, 2023
@Spacetown Spacetown marked this pull request as ready for review February 28, 2023 19:19
Spacetown added 2 commits March 7, 2023 19:41
@Spacetown
Replace comment with a single space.
1624bcf 
If a comment is replaced by a empty string the tokens before and behind will be concatenated which isn't expected.
@Spacetown
Use same variable for prepared string in all functions.
5c674bd
@codecov
Copy link
codecov bot commented Mar 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 82.60% and project coverage change: -1.38 ⚠️

Comparison is base (a9cc962) 95.64% compared to head (68bef3f) 94.27%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage   95.64%   94.27%   -1.38%     
==========================================
  Files          28       28              
  Lines        3857     3858       +1     
  Branches      670      671       +1     
==========================================
- Hits         3689     3637      -52     
- Misses         91      141      +50     
- Partials       77       80       +3
Flag Coverage Δ
ubuntu-20.04 94.27% <82.60%> (-0.08%) ⬇️
windows-2019 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/decision_analysis.py 87.64% <82.60%> (-2.84%) ⬇️
gcovr/tests/test_html_generator.py 50.00% <0.00%> (-50.00%) ⬇️
gcovr/utils.py 79.89% <0.00%> (-12.89%) ⬇️
gcovr/tests/test_gcovr.py 92.44% <0.00%> (-6.40%) ⬇️
gcovr/gcov.py 77.09% <0.00%> (-0.73%) ⬇️
gcovr/writer/html/__init__.py 94.94% <0.00%> (-0.51%) ⬇️
gcovr/coverage.py 97.22% <0.00%> (-0.33%) ⬇️
gcovr/workers.py 98.80% <0.00%> (-0.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Spacetown Spacetown force-pushed the decision_coverage_switch_case branch from cd38ce8 to 68bef3f Compare March 7, 2023 19:45
@Spacetown Spacetown merged commit 7093d2b into gcovr:master Mar 7, 2023
@Spacetown Spacetown deleted the decision_coverage_switch_case branch March 7, 2023 19:57
@Spacetown Spacetown mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

--decisions not effective in C switch statements
1 participant
@Spacetown
0