8000 Respect exclusion markers for functions by Spacetown · Pull Request #713 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Respect exclusion markers for functions #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 8, 2023
Merged

Respect exclusion markers for functions #713

merged 7 commits into from
Feb 8, 2023

Conversation

Spacetown
Copy link
Member

The exclusion markers where not applied to the function coverage. This PR extends the data model and the JSON format with the excluded flag for each function.

Closes #669

@Spacetown Spacetown added this to the 6.0 milestone Feb 7, 2023
@Spacetown Spacetown force-pushed the respect_excl_markers_for_functions branch from 2f8aa5c to 4c79b9b Compare February 8, 2023 20:42
@codecov
Copy link
codecov bot commented Feb 8, 2023 •
edited
Loading

Codecov Report

Base: 95.60% // Head: 95.62% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (61d0384) compared to base (f3ee007).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage   95.60%   95.62%   +0.02%     
==========================================
  Files          28       28              
  Lines        3797     3819      +22     
  Branches      658      665       +7     
==========================================
+ Hits         3630     3652      +22     
  Misses         91       91              
  Partials       76       76
Flag Coverage Δ
ubuntu-20.04 94.60% <100.00%> (+0.03%) ⬆️
windows-2019 95.30% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/tests/test_args.py 98.91% <ø> (ø)
gcovr/coverage.py 97.54% <100.00%> (+0.03%) ⬆️
gcovr/exclusions/markers.py 100.00% <100.00%> (ø)
gcovr/gcov_parser.py 97.63% <100.00%> (ø)
gcovr/merging.py 87.02% <100.00%> (+0.62%) ⬆️
gcovr/writer/html.py 95.45% <100.00%> (+0.01%) ⬆️
gcovr/writer/json.py 97.20% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Spacetown Spacetown force-pushed the respect_excl_markers_for_functions branch from 4c79b9b to 61d0384 Compare February 8, 2023 20:51
@Spacetown Spacetown marked this pull request as ready for review February 8, 2023 21:23
@Spacetown Spacetown merged commit 5ea4195 into gcovr:master Feb 8, 2023
@Spacetown Spacetown deleted the respect_excl_markers_for_functions branch February 8, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

GCOVR_EXCL_START applies to line and branch coverage but not function coverage
1 participant
@Spacetown
0