Fix list options in configuration files. #612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #612 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 24 24
Lines 3317 3317
Branches 619 619
=======================================
Hits 3155 3155
Misses 92 92
Partials 70 70
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix options with more than one argument in configuration files.
The config key
search-pathwas stored as a single value. The iteration was done on the characters of the last config entry instead of the path entries.Only options with
nargs="*"are fixed. If a option with e.g. 2 arguments is added (I don't think we will add this in the near future) the code has to be adapted.Closes #608.