8000 Fix package level function coverage in cobertura. by Spacetown · Pull Request #605 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix package level function coverage in cobertura. #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 8, 2022
Merged

Fix package level function coverage in cobertura. #605

merged 3 commits into from
Apr 8, 2022

Conversation

Spacetown
Copy link
Member

As mentioned in #600 the package level function coverage was wrong. This commit fixes this.

@Spacetown Spacetown added this to the 5.2 milestone Apr 7, 2022
@Spacetown Spacetown requested a review from latk April 7, 2022 19:41
@codecov
Copy link
codecov bot commented Apr 7, 2022 •
edited
Loading

Codecov Report

Merging #605 (d5633a3) into master (7df54c2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #605   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          24       24           
  Lines        3313     3313           
  Branches      617      617           
=======================================
  Hits         3151     3151           
  Misses         92       92           
  Partials       70       70
Flag Coverage Δ
ubuntu-18.04 93.89% <100.00%> (ø)
windows-2019 94.74% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/writer/cobertura.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df54c2...d5633a3. Read the comment docs.

latk
latk approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member
@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the reference files now look more correct.

@Spacetown @latk
Update CHANGELOG.rst
d5633a3 
Co-authored-by: Lukas Atkinson <opensource@LukasAtkinson.de>
@Spacetown
Copy link
Member Author

Looks good, the reference files now look more correct.

I've checked some random files. It would be easier if we add line breaks to the reference files.

@Spacetown Spacetown merged commit bfd364e into gcovr:master Apr 8, 2022
@Spacetown Spacetown deleted the fix_package_level_function_coverage_in_cobertura branch April 8, 2022 15:57
@latk
Copy link
Member
latk commented Apr 8, 2022

It would be easier if we add line breaks to the reference files.

If you want to enable --cobertura-pretty in the tests I have no objections, provided that at least one test without this option exists.

@Spacetown Spacetown mentioned this pull request Apr 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latk latk latk approved these changes

Assignees
No one assigned
Labels
Format: Cobertura Type: Bug
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Spacetown @latk
0