Fix black check: Option --check needed. #594
Conversation
d832e23 to
a080622
Compare
a080622 to
63b88a6
Compare
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
==========================================
- Coverage 95.63% 94.49% -1.15%
==========================================
Files 23 23
Lines 3342 3340 -2
Branches 611 611
==========================================
- Hits 3196 3156 -40
- Misses 73 108 +35
- Partials 73 76 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -97,7 +97,9 @@ def black(session: nox.Session) -> None: | |||
| if session.posargs: | |||
| session.run("python", "-m", "black", *session.posargs) | |||
| else: | |||
| session.run("python", "-m", "black", "--diff", *DEFAULT_LINT_ARGUMENTS) | |||
| session.run( | |||
There was a problem hiding this comment.
Is the black session supposed to reformat files, or to check for correct formatting? Depending on whether session arguments are provided this will do different things. Instead of adding --check, removing --diff might be a better solution.
| - Fix parallel processing of gcov data (:issue:`592`) | ||
| - Remove function coverage from sonarcube report. (:issue:`591`) | ||
| - Fix parallel processing of gcov data. (:issue:`592`) | ||
| - Fix black session to fail on format errors. (:issue:`594`) |
There was a problem hiding this comment.
This is an internal change, so the changelog entry should be moved to the other section.
The option was removed by accident when reformatting all files and apply check to all files. Session isn't failing on error.