8000 Don't use realpath in data model, only use them for the filter by Spacetown · Pull Request #565 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Don't use realpath in data model, only use them for the filter #565

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 15, 2022
Merged

Don't use realpath in data model, only use them for the filter #565

merged 8 commits into from
Mar 15, 2022

Conversation

Spacetown
Copy link
Member

With this PR the paths in the data model aren't changed to realpath anymore. Only in the filter or the HTML output the paths are changed to realpaths. This should workaround #365.

The test results aren't affected by this change.

@Spacetown Spacetown added this to the 5.1 milestone Jan 31, 2022
@Spacetown Spacetown requested a review from latk January 31, 2022 20:30
@codecov
Copy link
codecov bot commented Jan 31, 2022 •
edited
Loading

Codecov Report

Merging #565 (6eae165) into master (65f13eb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   95.68%   95.70%   +0.01%     
==========================================
  Files          23       23              
  Lines        3294     3305      +11     
  Branches      609      610       +1     
==========================================
+ Hits         3152     3163      +11     
  Misses         69       69              
  Partials       73       73
Flag Coverage Δ
ubuntu-18.04 94.48% <63.33%> (-0.26%) ⬇️
windows-2019 95.32% <96.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/gcov.py 82.12% <100.00%> (ø)
gcovr/tests/test_gcovr.py 97.66% <100.00%> (+0.12%) ⬆️
gcovr/utils.py 91.22% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f13eb...6eae165. Read the comment docs.

@Spacetown Spacetown force-pushed the fix_path_handling branch 5 times, most recently from 801851d to fb2c588 Compare March 12, 2022 21:26
@Spacetown Spacetown mentioned this pull request Mar 12, 2022
Closed
latk
latk approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member
@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be merged and would likely improve the state of things :)

Nevertheless, some comments. The Remark is just me thinking out loud. The ones marked Style are entirely optional.

gcovr/tests/test_gcovr.py Outdated Show resolved Hide resolved
@Spacetown
Copy link
Member Author

The test for Ubuntu-20.04 should be ignored at the moment, see actions/runner-images#5237.

@Spacetown Spacetown merged commit a509f85 into gcovr:master Mar 15, 2022
@Spacetown Spacetown deleted the fix_path_handling branch March 15, 2022 21:09
@Spacetown Spacetown mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latk latk latk approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Spacetown @latk
0