Drop support for Python 3.6 #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
=======================================
Coverage 96.10% 96.10%
=======================================
Files 22 22
Lines 2975 2975
Branches 558 558
=======================================
Hits 2859 2859
Misses 51 51
Partials 65 65
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Should this be part of the 5.1? |
|
We could hold off from this change until 5.1 is released so that 5.1 would be the final gcovr version with Python 3.6 support. But I see no advantage from that since Python 3.6 is end-of-life. So I'd merge it now if that is fine with you. |
|
Please merge it back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.6 was EOL'ed on 23 Dec 2021. In line with gcovr's support policy for Python versions, this pull request removes support for Python 3.6.
References: PEP 494 (Python 3.6 Release Schedule), endoflife.date/python
This has no strong immediate benefits, but will allow us to use more modern Python features in the future. Highlight features of Python 3.7 include:
dataclassesto easily define struct-like classes. Could simplify a lot of places where we currently pass around tuples!from __future__ import annotationsfor easier type annotationsFollowing this PR, I plan to submit patches that introduce more type checking, with the eventual goal of enabling
mypyas a linter. While using a type checker sometimes requires writing the code a bit differently, it is my experience that this can detect some bugs up front – a good counterpart to our test suite. It is also my hope that such type annotations will make other refactorings safer, make it easier to navigate the codebase, and help other people contribute more easily.