Split examples because the details are changed after every test run. #543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 21 21
Lines 2855 2855
Branches 532 532
=======================================
Hits 2743 2743
Misses 49 49
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Splitting the examples is quite reasonable. But skipping an example for the tests might not be a good idea. I just implemented #546 which makes it possible to have reproducible reports that do not change the timestamp in the report. Could you take a look to see if that kind of feature would make sense in this context? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #525 where the test of the examples was extended with csv, json and html the files with the details where changed on every run. Now the HTML test is splitted and the call for the details is only used when generating the docs.
[no changelog]