8000 Fix globbing of reference data by Spacetown · Pull Request #533 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix globbing of reference data #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2021
Merged

Fix globbing of reference data #533

merged 3 commits into from
Dec 13, 2021

Conversation

Spacetown
Copy link
Member

Fix bug found in #531.

@Spacetown Spacetown added this to the UpcomingRelease milestone Dec 8, 2021
@codecov
Copy link
codecov bot commented Dec 8, 2021 •
edited
Loading

Codecov Report

Merging #533 (bde994b) into master (044b5c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #533   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files          21       21           
  Lines        2837     2837           
  Branches      485      527   +42     
=======================================
  Hits         2728     2728           
  Misses         48       48           
  Partials       61       61
Flag Coverage Δ
ubuntu-18.04 95.66% <ø> (ø)
windows-2019 95.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/tests/test_gcovr.py 98.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044b5c9...bde994b. Read the comment docs.

@Spacetown Spacetown added Internal change Internal change not visible to user QA related to testing, build infrastructure, etc labels Dec 8, 2021
latk
latk approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member
@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for finding and fixing this problem :)

@Spacetown Spacetown merged commit b127d4e into gcovr:master Dec 13, 2021
@Spacetown Spacetown deleted the fix_globbing_of_reference_data branch December 13, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latk latk latk approved these changes

Assignees
No one assigned
Labels
Internal change Internal change not visible to user needs review QA related to testing, build infrastructure, etc Type: Bug
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Spacetown @latk
0