8000 Activate symlink tests under Windows by Spacetown · Pull Request #539 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Activate symlink tests under Windows #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 18, 2021
Merged

Activate symlink tests under Windows #539

merged 6 commits into from
Dec 18, 2021

Conversation

Spacetown
Copy link
Member

Under Windows we have to use junctions instead of symlinks. As I know a Shell can't cd into a symbolic link.
With Junctions and a custom gcov_realpath for python < 3.8 the tests are now working also on windows.
With this change #535 should change the gcov_realpath to not resolve the path to a different drive on windows.

@Spacetown Spacetown added Type: Enhancement Platform: Windows QA related to testing, build infrastructure, etc labels Dec 16, 2021
@Spacetown Spacetown added this to the 5.1 milestone Dec 16, 2021
@codecov
Copy link
codecov bot commented Dec 16, 2021 •
edited
Loading

Codecov Report

Merging #539 (2d8f123) into master (6a79a04) will decrease coverage by 0.08%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   96.15%   96.07%   -0.09%     
==========================================
  Files          21       21              
  Lines        2837     2854      +17     
  Branches      527      532       +5     
==========================================
+ Hits         2728     2742      +14     
- Misses         48       49       +1     
- Partials       61       63       +2
Flag Coverage Δ
ubuntu-18.04 95.12% <40.00%> (-0.54%) ⬇️
windows-2019 95.90% <76.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcovr/tests/test_gcovr.py 97.98% <ø> (-0.02%) ⬇️
gcovr/utils.py 91.45% <84.61%> (-0.68%) ⬇️
gcovr/gcov.py 81.59% <100.00%> (ø)
gcovr/writer/html.py 96.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a79a04...2d8f123. Read the comment docs.

latk
latk approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member
@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing that this works! Thank you for implementing this. I see no bugs, but have a couple of questions/comments.

@Spacetown
Add review remarks.
e76fdf4 
Remove different filter for windows.
Rename gcov_realpath to realpath.
@Spacetown Spacetown marked this pull request as draft December 18, 2021 14:57
@Spacetown Spacetown force-pushed the symlinks_under_windows branch 3 times, most recently from 88420b6 to 55cc7b8 Compare December 18, 2021 19:07
@Spacetown Spacetown force-pushed the symlinks_under_windows branch from 55cc7b8 to 2d8f123 Compare December 18, 2021 19:13
@Spacetown Spacetown marked this pull request as ready for review December 18, 2021 19:21
@Spacetown Spacetown merged commit 3ca02f2 into gcovr:master Dec 18, 2021
@Spacetown Spacetown deleted the symlinks_under_windows branch December 18, 2021 19:23
@Spacetown Spacetown mentioned this pull request Dec 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latk latk latk approved these changes

Assignees
No one assigned
Labels
Platform: Windows QA related to testing, build infrastructure, etc Type: Enhancement
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Spacetown @latk
0