8000 Change Version numbers to strings by Jugst3r · Pull Request #418 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Change Version numbers to strings #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2020
Merged

Change Version numbers to strings #418

merged 3 commits into from
Sep 17, 2020

Conversation

Jugst3r
Copy link
Contributor
@Jugst3r Jugst3r commented Sep 16, 2020

Quick fix, tests should be clean

@codecov
Copy link
codecov bot commented Sep 16, 2020 •
edited
Loading

Codecov Report

Merging #418 into master will increase coverage by 0.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   93.72%   94.68%   +0.95%     
==========================================
  Files          20       20              
  Lines        2311     2351      +40     
  Branches      404      407       +3     
==========================================
+ Hits         2166     2226      +60     
+ Misses         77       56      -21     
- Partials       68       69       +1
Impacted Files Coverage Δ
gcovr/tests/test_args.py 100.00% <ø> (ø)
gcovr/json_generator.py 100.00% <100.00%> (ø)
gcovr/utils.py 88.35% <0.00%> (-3.71%) ⬇️
gcovr/gcov.py 86.51% <0.00%> (-0.59%) ⬇️
gcovr/configuration.py 97.67% <0.00%> (ø)
gcovr/html_generator.py 98.36% <0.00%> (+0.19%) ⬆️
gcovr/tests/test_gcovr.py 92.66% <0.00%> (+0.61%) ⬆️
gcovr/__main__.py 91.20% <0.00%> (+1.38%) ⬆️
gcovr/coveralls_generator.py 93.39% <0.00%> (+26.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e8776...2645888. Read the comment docs.

latk
latk approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member
@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks! For completeness sake, could you also add your name or alias to the AUTHORS file?

@latk latk linked an issue Sep 16, 2020 that may be closed by this pull request
Change JSON_FORMAT_VERSION to String #417
Closed
@Spacetown
Copy link
Member

@latk I'm wondering about the coverage report. There are files listed which are not changed in this PR (Last update 73e8776...2645888.). Commit 73e8776 is #405 which is 8 days old.

@latk
Copy link
Member
latk commented Sep 16, 2020

@Spacetown Yeah, Codecov produces really weird/misleading summaries. Apparently it doesn't compare coverage state with the master branch but with the parent commit. The first commit of this PR is 4cf2b91, the parent of which is indeed 73e8776.

@Spacetown
Copy link
Member

@latk Ok. I thought this is because I did something wrong when switching to GitHub.

Spacetown
Spacetown approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member
@Spacetown Spacetown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@Spacetown Spacetown merged commit 1bc72e3 into gcovr:master Sep 17, 2020
@Spacetown Spacetown added this to the 4.3 milestone Oct 7, 2020
@CezaryGapinski CezaryGapinski mentioned this pull request Feb 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latk latk latk approved these changes

@Spacetown Spacetown Spacetown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Change JSON_FORMAT_VERSION to String
3 participants
@Jugst3r @Spacetown @latk
0