8000 Add support for output directory by Spacetown · Pull Request #416 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for output directory #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2020
Merged

Add support for output directory #416

merged 2 commits into from
Dec 10, 2020

Conversation

Spacetown
Copy link
Member

Support for output directory as mentioned in #43

@Spacetown Spacetown mentioned this pull request Sep 13, 2020
Closed
@Spacetown Spacetown force-pushed the add_support_for_output_directory branch from c0d49a2 to aee32a3 Compare September 14, 2020 18:25
latk
latk reviewed Sep 14, 2020
View reviewed changes
Copy link
Member
@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working on this frequently-requested feature. This looks pretty good, though I have some doubts about the data flow around check_output_file(). It took me very long to convince myself that everything would work correctly also with values from config files.

Unfortunately I saved some comments before the last push, so they might already be marked as outdated 😅

@Spacetown Spacetown force-pushed the add_support_for_output_directory branch 5 times, most recently from e0ae8a0 to 8597789 Compare September 20, 2020 19:17
@codecov
Copy link
codecov bot commented Sep 20, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2a86dee). Click here to learn what that means.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #416   +/-   ##
=========================================
  Coverage          ?   95.01%           
=========================================
  Files             ?       20           
  Lines             ?     2405           
  Branches          ?      415           
=========================================
  Hits              ?     2285           
  Misses            ?       55           
  Partials          ?       65
Impacted Files Coverage Δ
gcovr/html_generator.py 96.78% <69.23%> (ø)
gcovr/txt_generator.py 94.59% <94.44%> (ø)
gcovr/__main__.py 92.16% <100.00%> (ø)
gcovr/cobertura_xml_generator.py 98.00% <100.00%> (ø)
gcovr/configuration.py 99.28% <100.00%> (ø)
gcovr/coveralls_generator.py 93.20% <100.00%> (ø)
gcovr/csv_generator.py 100.00% <100.00%> (ø)
gcovr/json_generator.py 100.00% <100.00%> (ø)
gcovr/sonarqube_generator.py 100.00% <100.00%> (ø)
gcovr/tests/test_args.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a86dee...5f2cdaa. Read the comment docs.

@Spacetown Spacetown marked this pull request as ready for review September 21, 2020 12:10
@Spacetown Spacetown requested a review from latk September 23, 2020 18:22
@Spacetown Spacetown force-pushed the add_support_for_output_directory branch from 8597789 to a372a9b Compare September 25, 2020 19:14
@Spacetown Spacetown force-pushed the add_support_for_output_directory branch from a372a9b to e91c4a3 Compare October 3, 2020 21:18
@Spacetown Spacetown force-pushed the add_support_for_output_directory branch from e91c4a3 to 3d18542 Compare November 20, 2020 21:06
@Spacetown Spacetown force-pushed the add_support_for_output_directory branch from 3d18542 to 91c590e Compare November 30, 2020 20:31
@Spacetown
Add support for output directory
b658c36 
Support for output directory as mentioned in gcovr#43

Fix test
@Spacetown Spacetown force-pushed the add_support_for_output_directory branch from 91c590e to b658c36 Compare December 3, 2020 19:58
latk
latk approved these changes Dec 10, 2020
View reviewed changes
Copy link
Member
@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to be merged! I found the diff fairly hard to read, but that's partially due to having forgotten about the context of this PR, partially due to the not very explicit data model we are using.

E.g. I was wondering about whether filename.endswith(os.path.sep) would also work as expected on Windows. Turns out yes because the paths are normalized during configuration/options handling. But the connection isn't obvious because the path is just a string. I think there is a future opportunity to clarify the data flows (also because we can now use type annotations), but definitely not as part of this PR.

Thanks for the work on this!

@Spacetown Spacetown merged commit 38668d0 into gcovr:master Dec 10, 2020
@Spacetown Spacetown deleted the add_support_for_output_directory branch December 10, 2020 19:35
@Spacetown Spacetown added this to the 4.3 milestone Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latk latk latk approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Spacetown @latk
0