8000 Add linkable lines in HTML details. by Spacetown · Pull Request #401 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add linkable lines in HTML details. #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2020
Merged

Add linkable lines in HTML details. #401

merged 3 commits into from
Jul 30, 2020

Conversation

Spacetown
Copy link
Member

Add linkable lines as listed in #43.

@Spacetown Spacetown requested a review from latk July 28, 2020 20:29
@codecov
Copy link
codecov bot commented Jul 28, 2020 •
8000
edited
Loading

Codecov Report

Merging #401 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files          19       19           
  Lines        2193     2193           
  Branches      379      379           
=======================================
  Hits         2084     2084           
  Misses         49       49           
  Partials       60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1965797...f9288da. Read the comment docs.

latk
latk approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member
@latk latk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small but good change. The ability to automatically regenerate reference files really pays off!

I haven't looked at the live pages but I have a hunch that a CSS rule to remove link underlines might be useful:

.lineno > a { text-decoration: none; color: inherit; }

(untested)

@Spacetown
Copy link
Member Author

I was also thinking about this but didn't remove it to show the link to the user.
I'll remove the decoration here fot a better readable report.

Yes, the regeneration is very good for such changes. :-)

@Spacetown Spacetown merged commit 0eff148 into gcovr:master Jul 30, 2020
@Spacetown Spacetown deleted the linkable_lines branch July 30, 2020 19:38
@Spacetown Spacetown added this to the 4.3 milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latk latk latk approved these changes

Assignees
No one assigned
Labels
Format: HTML Type: Enhancement
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Spacetown @latk
0