8000 Configure tab size for HTML source page #277 by Spacetown · Pull Request #377 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Configure tab size for HTML source page #277 #377

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2020
Merged

Configure tab size for HTML source page #277 #377

merged 1 commit into from
May 29, 2020

Conversation

Spacetown
Copy link
Member

No description provided.

@codecov
Copy link
codecov bot commented May 27, 2020 •
edited
Loading

Codecov Report

Merging #377 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   94.49%   94.51%   +0.02%     
==========================================
  Files          18       18              
  Lines        2089     2098       +9     
  Branches      366      367       +1     
==========================================
+ Hits         1974     1983       +9     
  Misses         55       55              
  Partials       60       60
8000
Impacted Files Coverage Δ
gcovr/configuration.py 97.47% <ø> (ø)
gcovr/__main__.py 89.47% <100.00%> (+0.15%) ⬆️
gcovr/html_generator.py 95.41% <100.00%> (+0.02%) ⬆️
gcovr/tests/test_args.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d161afd...a31e582. Read the comment docs.

latk
latk reviewed May 28, 2020
View reviewed changes
gcovr/templates/style.css Outdated
Comment on lines 245 to 246
tab-size: 3;
-moz-tab-size: 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I respect both sides in the tabs vs spaces debate, but tab-size: 3 feels like it would make nearly no one happy :)

If we're going to set a default, maybe tab-size: 4? Should we introduce a --html-tab-size option, or is that a YAGNI feature right now?

Btw it also seems like a .DS_Store file made it through the gitignore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add an option for this. Shall we add the CSS only if the option is set?
I'll remove the .DS_STORE and add this to .gitignore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the default tab size is 8, it should always be set explicitly. The Linux kernel is the only project I know that assumes 8, everyone else seems to default to something in the range 2–4. Using 4 is probably a sane default.

@Spacetown Spacetown force-pushed the set_tab_size branch 3 times, most recently from 94ff2a4 to c19993b Compare May 28, 2020 20:58
@latk latk merged commit db8f162 into gcovr:master May 29, 2020
@latk latk mentioned this pull request May 29, 2020
Closed
@Spacetown Spacetown deleted the set_tab_size branch May 29, 2020 18:50 6E5A
@Spacetown Spacetown added this to the 4.3 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@latk latk latk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Spacetown @latk
0