8000 gcovr RelativeFilter is relative to os.getcwd, should be relative to --root · Issue #319 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

gcovr RelativeFilter is relative to os.getcwd, should be relative to --root #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tsondergaard opened this issue Jun 17, 2019 · 2 comments · Fixed by #405
Closed

gcovr RelativeFilter is relative to os.getcwd, should be relative to --root #319

tsondergaard opened this issue Jun 17, 2019 · 2 comments · Fixed by #405
Labels
Docs related to the documentation or website Filters related to filters, include/exclude, path handling Type: Enhancement

Comments

@tsondergaard
Copy link

--exclude filters were not working for me, because I did not expect them to be relative to the current working directory. I expected them to be relative to the option provided with --root.
@latk
Copy link
Member
latk commented Jun 17, 2019

This is a design decision that can't be changed without breaking backwards compatibility.

However, the documentation could be more explicit about this so I'm leaving this issue open as a reminder.

@latk latk added Docs related to the documentation or website Filters related to filters, include/exclude, path handling Type: Enhancement labels Jun 17, 2019
@tsondergaard
Copy link
Author

@latk thanks for the fast response. I think you are right that it would be a good idea to document that the current working directory is important regardless of whether --root is passed.

Spacetown added a commit to Spacetown/gcovr that referenced this issue Aug 10, 2020
@Spacetown
Extend documentation for relative filters (gcovr#319)
4984959
@Spacetown Spacetown mentioned this issue Aug 10, 2020
Merged
Spacetown added a commit to Spacetown/gcovr that referenced this issue Aug 14, 2020
@Spacetown
Extend documentation for relative filters (gcovr#319)
d090d40
Spacetown added a commit to Spacetown/gcovr that referenced this issue Sep 2, 2020
@Spacetown
Extend documentation for relative filters (gcovr#319)
c4ee24a
Spacetown added a commit to Spacetown/gcovr that referenced this issue Sep 8, 2020
@Spacetown
Extend documentation for relative filters (gcovr#319)
bf9ae7a
Spacetown added a commit that referenced this issue Sep 8, 2020
@Spacetown
Extend documentation for relative filters (#319) (#405)
73e8776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Docs related to the documentation or website Filters related to filters, include/exclude, path handling Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend documentation for relative filters Spacetown/gcovr
2 participants
@latk @tsondergaard
0