HTML Title inconsequential #296
Comments
|
Hi, I actually have a private branch where I've started cleaning up the
HTML templates (mostly removing the table-based layout and Internet
Explorer compatibility things). Instead of changing text occurrences
manually I instead run a Perl script with some regexes over the test suite …
Your point that the title is pointless is very good, and I'll try to fix
that the next time I touch Gcovr. However, I cannot give you an ETA when
that will be. It's great that you've looked for ways to fix this yourself
(thank you!) but in this particular case I'd prefer to do it myself to
prevent merge conflicts.
… |
|
Yeah absolutely, I prefer not touching anything html since I know so little about it. |
|
Shall the "GCC Code Coverage Report" be replaced or extended by the given title? |
|
We have two defaults for the title:
|
|
I have no idea why the title ever said “Head”. Ideally, the HTML title would just default to |
|
Before I introduced the '--title' option the title was hardcoded to "Head", this was the reason for using this as a default. But I'll change the default and update the test data. |
|
#374 would be great for updating the test data. :-) |
- Default for option --title changed to "GCC Code Coverage Report".
|
Search and replace with RegEx did a great work. |
- Default for option --title changed to "GCC Code Coverage Report".
|
Fixed by #378, thanks to @Spacetown! |
First I would say I know almost nothing about html. Hopefully, what I say still makes sense :)
It appears the argument I pass to
--html-titleends up being set in the html report's<head>section's title, not the<body>'s title. The effect I'm seeing is that the--html-titleargument controls the name of the tab in my browser, but the report itself still has the title ofGCC Code Coverage Report.Usually my browser tabs are not even wide enough to even show the full title. I think it makes more sense for the
--html-titleto set the title of the report I see, rather than then tab name.I tried looking how I would make this change myself in the code, but there are just so many instances of
GCC Code Coverage Reportin the repo, that I didn't know which I actually need to change.The text was updated successfully, but these errors were encountered: