8000 Provide css/template overrides for the html output. · Issue #25 · gcovr/gcovr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Provide css/template overrides for the html output. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lu-zero opened this issue Nov 3, 2013 · 15 comments
Closed

Provide css/template overrides for the html output. #25

lu-zero opened this issue Nov 3, 2013 · 15 comments
Labels
Format: HTML Type: Enhancement

Comments

@lu-zero
Copy link
lu-zero commented Nov 3, 2013

Beside what lcov does, would be nice having proper templating so a twitter bootstrap structure can be leveraged.
@whart222
Copy link
Member
whart222 commented Nov 7, 2013

Can you provide more details? What are you referring to w.r.t. what lcov does? What does proper templating mean?

I'm not familiar with twitter bootstrap, so I didn't consider this when generating the HTML pages. (In fact, doing something quick-and-easy was really the goal ...).

@lu-zero
Copy link
Author
lu-zero commented Nov 7, 2013

What I'd consider neat if you accept an additional dependency is to use
jinja2 templates and let the user write overrides
to it.

Twitter bootstrap has a series of css rules that are almost semantic and
overall make easier theming them instead of using custom names.

lcov takes some html fragments to replace the header and the trailer of the
generated page as well the ability of overriding the css.

Since we are using python and there are great tools I'd use them, if you
like the idea I can came up with a patch for it.

On Thu, Nov 7, 2013 at 1:30 AM, William Hart notifications@github.comwrote:

Can you provide more details? What are you referring to w.r.t. what lcov
does? What does proper templating mean?

I'm not familiar with twitter bootstrap, so I didn't consider this when
generating the HTML pages. (In fact, doing something quick-and-easy was
really the goal ...).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-27928143
.

@whart222
Copy link
Member

I would love to see a patch for this!

@lu-zero
Copy link
Author
lu-zero commented Nov 18, 2013

I started working on it, I'm doing in in steps

  • Move to use Template from jinja2 (done)
  • Refactor the line templates inside jinja2 (since there is an iterator in the template)
  • Provide a mean to output the default templates (if we keep the single script approach)
  • Provide a mean to override the templates

For bootstrap support I'll need to change the tests as well I guess.

@whart222
Copy link
Member

FYI, the tests currently don't verify that we generate expected HTML
output. The test Makefiles include html targets, but I've only used those
interactively to 'test' the HTML generation.

So ... I don't think you need to change any tests.

--Bill

On Mon, Nov 18, 2013 at 4:56 AM, Luca Barbato notifications@github.comwrote:

I started working on it, I'm doing in in steps

  • Move to use Template from jinja2 (done)
  • Refactor the line templates inside jinja2 (since there is an
    iterator in the template)
  • Provide a mean to output the default templates (if we keep the
    single script approach)
  • Provide a mean to override the templates

For bootstrap support I'll need to change the tests as well I guess.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/25#issuecomment-28692583
.

@lu-zero
Copy link
Author
lu-zero commented Dec 16, 2013

I made some progress, but would be probably better make a package out of a module split out of the large gcovr and the standard css and template.

1

The stripe effect isn't there yet since stripe and coloring in bootstrap3 doesn't work as expected (I'll report a fix for them soon)

@lu-zero
Copy link
Author
lu-zero commented Dec 25, 2013

Some progress

1

syntax highlighting using pygments got integrated more or less decently

@whart222 whart222 modified the milestones: WishList, Gcovr 3.2 Jul 4, 2014
@carlos-jenkins
Copy link
Contributor

Pygments? This is simply awesome, I was looking for that.

@carlos-jenkins carlos-jenkins mentioned this issue Jul 14, 2014
Closed
@tytouf
Copy link
tytouf commented Jan 7, 2015

@lu-zero What is the status on this work? this looks really nice but it appears it has not been integrated yet.

@lu-zero
Copy link
Author
lu-zero commented Jan 7, 2015

It lives in my branch and I think somebody volunteered to integrate it by
reimplementing at least part of it so waited to not step on his feet.

On Wed, Jan 7, 2015 at 11:53 AM, Christophe Augier <notifications@github.com

wrote:

@lu-zero https://github.com/lu-zero What is the status on this work?
this looks really nice but it appears it has not been integrated yet.

—
Reply to this email directly or view it on GitHub
#25 (comment).

@pranavpsawant
Copy link

Did we get a chance to integrate it ... because it looks super awesome....

@davidvanwyk
Copy link

I'd also love for this to be implemented - something akin to doxygen-bootstrapped would be fantastic.

@lu-zero
Copy link
Author
lu-zero commented Jan 2, 2018

The code is still on my tree :) anybody willing to help me get it merged is welcome.

@latk latk mentioned this issue Mar 5, 2018
Merged
@oesteban-vx oesteban-vx mentioned this issue Oct 9, 2020
Closed
@oesteban-vx
Copy link

So, this is related (implemented?) by #380?

@Spacetown
Copy link
Member

@oesteban-vx yes.

@Spacetown Spacetown removed this from the WishList milestone Jun 8, 2021
@latk latk mentioned this issue Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Format: HTML Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@lu-zero @whart222 @tytouf @carlos-jenkins @latk @pranavpsawant @davidvanwyk @Spacetown @oesteban-vx
0