8000 Update the reference for the `creasey2013` `stellarFeedbackOutflows` class by abensonca · Pull Request #857 · galacticusorg/galacticus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update the reference for the creasey2013 stellarFeedbackOutflows class #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 7, 2025
Merged

Update the reference for the creasey2013 stellarFeedbackOutflows class #857

merged 7 commits into from
Jun 7, 2025

Conversation

abensonca
Copy link
Collaborator

Modifies the class name so requires modification to parameter files.

abensonca added 3 commits June 5, 2025 14:55
@abensonca
fix!: Update the reference for the creasey2013 `stellarFeedbackOutf…
2af8b4d 
…lows` class

BREAKING CHANGE: Modifies the class name sdo requires modification to parameter files.
@abensonca
feat: Add a parameter migration for the stellarFeedbackOutflows cla…
21016a9 
…ss `creasey2012` -> `creasey2013`
@abensonca
fix: Ensure that the lastModified element is updated in all `parame…
a0bf1a3 
…ters` groups
@abensonca abensonca self-assigned this Jun 6, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 6, 2025

⚠️ Possible misspelled word 'beta0' in file 'source/stellar_feedback.outflows.Creasey2013.F90'
⚠️ Possible misspelled word 'beta0' in file 'source/stellar_feedback.outflows.Creasey2013.F90'

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 7, 2025

⚠️ Possible misspelled word 'beta0' in file 'source/stellar_feedback.outflows.Creasey2013.F90'
⚠️ Possible misspelled word 'beta0' in file 'source/stellar_feedback.outflows.Creasey2013.F90'

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 7, 2025

⚠️ Possible misspelled word 'beta0' in file 'source/stellar_feedback.outflows.Creasey2013.F90'
⚠️ Possible misspelled word 'beta0' in file 'source/stellar_feedback.outflows.Creasey2013.F90'

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 7, 2025

⚠️ Possible misspelled word 'beta0' in file 'source/stellar_feedback.outflows.Creasey2013.F90'
⚠️ Possible misspelled word 'beta0' in file 'source/stellar_feedback.outflows.Creasey2013.F90'

github-actions[bot]
github-actions bot reviewed Jun 7, 2025
View reviewed changes
Copy link
@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Decaying dark matter-only subhalos benchmarks (τ=20 Gyr; vₖ=40 km/s)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 5.

Benchmark suite Current: 39e59be Previous: 0bbebfa Ratio
(τ=20.0 Gyr; vₖ=40.0 km/s) - Likelihood - orbital radius function 129.2638883601037 -logℒ 25.158158135307495 -logℒ 5.14

This comment was automatically generated by workflow using github-action-benchmark.

CC: @abensonca

@abensonca abensonca added this pull request to the merge queue Jun 7, 2025
Merged via the queue into master with commit e81c6e6 Jun 7, 2025
312 checks passed
@abensonca abensonca deleted the fixUpdateCreasey2013 branch June 7, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@abensonca abensonca

Labels
feedback parameters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abensonca
0