8000 Fix array index loss after compilation by Sway007 · Pull Request #2111 · galacean/engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix array index loss after compilation #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jun 13, 2024
Merged

Fix array index loss after compilation #2111

merged 23 commits into from
Jun 13, 2024

Conversation

Sway007
Copy link
Member
@Sway007 Sway007 commented Jun 12, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix the array index loss in ShaderLab compilation:

// source
vec3 tangentW = v.TBN[0];

compiled

// before
vec3 tangentW = TBN;

// Fixed
vec3 tangentW = TBN[0];

@Sway007
fix(shader-lab): compatible with empty macro
5a26f3d
@Sway007
Merge branch 'main' of https://github.com/galacean/engine
5ecc318
@Sway007
Merge branch 'main' of https://github.com/galacean/engine
cafc24f
@Sway007
Merge branch 'main' of https://github.com/galacean/engine
dc69489
@Sway007
Merge branch 'main' of https://github.com/galacean/engine
221b7b6
@Sway007
fix(shader-lab): add break and continue syntax
0d45d9c
@Sway007
Merge branch 'main' of https://github.com/galacean/engine
0f14c3f
@Sway007
fix: typo
8871d9b
@Sway007
Merge branch 'main' of https://github.com/galacean/engine
3b4ffd7
@Sway007
fix(shader-lab): Make usepass compatible with buitin shader
f649a58
@Sway007
Merge branch 'main' of https://github.com/galacean/engine
598fc56
@Sway007
fix(shader-lab): compatible with no varying variable
e33a66f
@Sway007
feat(shader-lab): detect mismatch return type
41ef06f
@Sway007
fix(shader-lab): renderState assignment
b5214fc
@Sway007
feat: extend material loader data type
f36ce02
@Sway007
Merge branch 'main' of https://github.com/galacean/engine
ff8b7c2
@Sway007
fix(shader-lab): glsl type pattern
634236f
@Sway007
fix(shader-lab): glsl type pattern
91e6fa4
@Sway007
fix: switch case break
3932448
@Sway007
fix: array index loss
671cace
@Sway007
feat: merge
92b972e
@Sway007
fix: test-case
9226d38
@Sway007
fix: test-case
ff6a69a
@Sway007 Sway007 requested a review from GuoLei1990 June 12, 2024 02:13
@Sway007 Sway007 self-assigned this Jun 12, 2024
@Sway007 Sway007 added bug Something isn't working shader Shader related functions medium priority Medium priority issue labels Jun 12, 2024
@GuoLei1990 GuoLei1990 merged commit 69b92f6 into galacean:main Jun 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

Assignees

@Sway007 Sway007

Labels
bug Something isn't working medium priority Medium priority issue shader Shader related functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sway007 @GuoLei1990
0