8000 Fix blendshape error by GuoLei1990 · Pull Request #2043 · galacean/engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix blendshape error #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2024
Merged

Fix blendshape error #2043

merged 4 commits into from
Mar 18, 2024

Conversation

GuoLei1990
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@GuoLei1990 GuoLei1990 added the bug Something isn't working label Mar 18, 2024
@GuoLei1990 GuoLei1990 requested a review from gz65555 March 18, 2024 11:47
@codecov Codecov
Copy link
codecov bot commented Mar 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.06%. Comparing base (025033e) to head (d641128).
Report is 171 commits behind head on main.

Files Patch % Lines
packages/loader/src/gltf/parser/GLTFMeshParser.ts 86.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2043      +/-   ##
==========================================
- Coverage   67.46%   66.06%   -1.40%     
==========================================
  Files         471      460      -11     
  Lines       23809    22996     -813     
  Branches     3402     3369      -33     
==========================================
- Hits        16062    15193     -869     
- Misses       6556     6643      +87     
+ Partials     1191     1160      -31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 added the Animation Built-in animation system related functions label Mar 18, 2024
@GuoLei1990 GuoLei1990 merged commit 154f42a into galacean:main Mar 18, 2024
@luzhuang luzhuang mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gz65555 gz65555 gz65555 approved these changes

Assignees
No one assigned
Labels
Animation Built-in animation system related functions bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuoLei1990 @gz65555
0