8000 Fix invalid url by cptbtptpbcptdtptp · Pull Request #2652 · galacean/engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix invalid url #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Fix invalid url #2652

merged 1 commit into from
May 8, 2025

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator
@cptbtptpbcptdtptp cptbtptpbcptdtptp commented May 8, 2025 •
edited by coderabbitai bot
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the file URL scheme prefix from "files://" to the standard "file://", ensuring proper handling of local file URLs.

@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this May 8, 2025
@cptbtptpbcptdtptp cptbtptpbcptdtptp added the Bug Something isn't working label May 8, 2025
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 8, 2025 •
edited
Loading

Walkthrough

The update modifies the resolveAbsoluteUrl method in the Utils class by correcting the file URL scheme prefix from "files://" to the standard "file://". No other logic or public API signatures are changed.

Changes

File(s) Change Summary
packages/core/src/Utils.ts Fixed the file URL scheme prefix in resolveAbsoluteUrl from "files://" to "file://".

Poem

A slip of an "s" now set right,
"file://" shines in morning light.
No more plural, just one path,
Utils now avoids the wrath.
With every hop, the code grows neat—
A rabbit’s fix, precise and sweet! 🐇✨

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 69886a2 and 6ef7c04.

📒 Files selected for processing (1)
  • packages/core/src/Utils.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: build (22.x, windows-latest)
  • GitHub Check: e2e (22.x)
  • GitHub Check: codecov
🔇 Additional comments (1)
packages/core/src/Utils.ts (1)

82-82:

✅ Verification successful

Correctly fixed the file URL scheme

The change from "files://" to "file://" is correct and aligns with the standard URL scheme specification. The file:// scheme is the proper format to reference files in URLs, and this fix resolves potential URL resolution issues when working with file paths.

To ensure consistency, it would be good to check if there are any other occurrences of "files://" in the codebase:

🏁 Script executed:

#!/bin/bash
# Search for any other occurrences of the incorrect "files://" scheme
rg "files://" -g "*.{ts,js,tsx,jsx}" --line-number

Length of output: 50

No remaining files:// occurrences
A global ripgrep search (rg "files://" -g "*.{ts,js,tsx,jsx}") returned no matches. The change from "files://" to "file://" is complete and aligns with the standard URL scheme.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link
codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.92%. Comparing base (69886a2) to head (6ef7c04).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/Utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2652   +/-   ##
=======================================
  Coverage   68.91%   68.92%           
=======================================
  Files         961      961           
  Lines      100691   100691           
  Branches     8723     8727    +4     
=======================================
+ Hits        69395    69399    +4     
+ Misses      31036    31032    -4     
  Partials      260      260
Flag Coverage Δ
unittests 68.92% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GuoLei1990 GuoLei1990 merged commit aaee61f into galacean:main May 8, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

@gz65555 gz65555 gz65555 approved these changes

Assignees

@cptbtptpbcptdtptp cptbtptpbcptdtptp

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cptbtptpbcptdtptp @GuoLei1990 @gz65555
0