8000 Update physX wasm without assertions by luzhuang · Pull Request #2493 · galacean/engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update physX wasm without assertions #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 8, 2025
Merged

Update physX wasm without assertions #2493

merged 6 commits into from
Jan 8, 2025

Conversation

luzhuang
Copy link
Contributor
@luzhuang luzhuang commented Jan 8, 2025 •
edited by coderabbitai bot
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

  • Chores
    • Updated the source URL for loading the PhysX library in WebAssembly runtime mode.

@luzhuang luzhuang requested a review from GuoLei1990 January 8, 2025 06:13
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Jan 8, 2025 •
edited
Loading

Walkthrough

The pull request involves a minor update to the source URL for loading the PhysX library in the PhysXPhysics class. The change specifically modifies the WebAssembly runtime mode script source, replacing one URL with a slightly different one. This update appears to be related to updating the library's source location while maintaining the same overall initialization approach.

Changes

File Change Summary
packages/physics-physx/src/PhysXPhysics.ts Updated PhysX library WebAssembly source URL

Poem

🐰 A PhysX library's new home,
A URL change, a subtle roam,
Bytes dancing from server to code,
WebAssembly's magical load,
Physics magic, just a hop away! 🚀

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cdb7b57 and b6b1a03.

⛔ Files ignored due to path filters (1)
  • packages/physics-physx/libs/physx.release.wasm is excluded by !**/*.wasm
📒 Files selected for processing (1)
  • packages/physics-physx/src/PhysXPhysics.ts (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/physics-physx/src/PhysXPhysics.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@luzhuang luzhuang added the physics Engine's physical system label Jan 8, 2025
@luzhuang luzhuang added the ignore for release ignore for release label Jan 8, 2025
singlecoder
singlecoder approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member
@singlecoder singlecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@luzhuang luzhuang added this to the 1.4 milestone Jan 8, 2025
@codecov Codecov
Copy link
codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.45%. Comparing base (cdb7b57) to head (b6b1a03).
Report is 2 commits behind head on dev/1.4.

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/1.4    #2493      +/-   ##
===========================================
+ Coverage    68.44%   68.45%   +0.01%     
===========================================
  Files          923      923              
  Lines        95994    95994              
  Branches      8140     8140              
===========================================
+ Hits         65702    65712      +10     
+ Misses       30038    30028      -10     
  Partials       254      254
Flag Coverage Δ
unittests 68.45% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luzhuang luzhuang changed the title refactor: update wasm without assertions Update physX wasm without assertions Jan 8, 2025
@GuoLei1990 GuoLei1990 merged commit 0c340a2 into galacean:dev/1.4 Jan 8, 2025
9 checks passed
singlecoder pushed a commit to singlecoder/engine that referenced this pull request Jan 8, 2025
@luzhuang @singlecoder
Update physX wasm without assertions (galacean#2493)
dcdfc1a 
* refactor:  update physX wasm without assertions
This was referenced Jan 8, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request May 6, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

@singlecoder singlecoder singlecoder approved these changes

Assignees

@GuoLei1990 GuoLei1990

Labels
ignore for release ignore for release physics Engine's physical system
Projects
Physic
Status: Done
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@luzhuang @GuoLei1990 @singlecoder
0