8000 Fix Transform e2e error by cptbtptpbcptdtptp · Pull Request #2466 · galacean/engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ engine Public

Fix Transform e2e error #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2024
Merged

Fix Transform e2e error #2466

merged 2 commits into from
Dec 17, 2024

Conversation

cptbtptpbcptdtptp
Copy link
Collaborator
@cptbtptpbcptdtptp cptbtptpbcptdtptp commented Dec 16, 2024 •
edited by coderabbitai bot
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

  • New Features

    • Enhanced bounding box updates in the SkinnedMeshRenderer class based on skin configuration.
    • Improved shader data handling for skin updates, including macro management based on bone count and root bone changes.

  • Bug Fixes

    • Improved property access in the Transform class to enhance encapsulation.

  • Documentation

    • Updated comments and formatting for clarity.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Dec 16, 2024 •
edited
Loading

Walkthrough

The changes involve modifications to the _copyFrom method in the Transform class and several enhancements to the SkinnedMeshRenderer class. The _copyFrom method now utilizes public getters for position, rotation, and scale, improving encapsulation. In SkinnedMeshRenderer, the _updateBounds method includes a conditional check for rootBone, and the _onSkinUpdated method has been refined to manage shader data based on bone count and root bone changes. These updates enhance the control flow and robustness of both classes.

Changes

File Change Summary
packages/core/src/Transform.ts Updated _copyFrom method to use public getters (position, rotation, scale) instead of directly accessing private properties (_position, _rotation, _scale).
packages/core/src/mesh/SkinnedMeshRenderer.ts Modified _updateBounds to check for rootBone, refined _onSkinUpdated for bone count and root bone changes, and updated _applySkin for better listener management. Constructor initializes _skin to null, and _jointTexture is created with specific format and filter mode. Enhanced error handling for joint count exceeding device capabilities.

Possibly related PRs

  • Entity support add other Transform #2456: This PR optimizes the addition and replacement logic of the Transform, which is directly related to the changes made in the _copyFrom method of the Transform class in the main PR.
  • Replace Transform #2464: This PR focuses on replacing the Transform component, which is relevant as it may involve changes to the same class and its methods, including the _copyFrom method.

Suggested labels

high priority

Suggested reviewers

  • GuoLei1990
  • johanzhu

Poem

🐰 A rabbit's tale of getters so neat,
Transforming code with a magical feat.
No more direct access, we now embrace,
Public methods with elegant grace.
Encapsulation dances, properties shine bright! 🌟

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cptbtptpbcptdtptp cptbtptpbcptdtptp self-assigned this Dec 16, 2024
@cptbtptpbcptdtptp cptbtptpbcptdtptp added the Bug Something isn't working label Dec 16, 2024
@codecov Codecov
Copy link
codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.31%. Comparing base (1405f8b) to head (8872bbd).
Report is 1 commits behind head on dev/1.4.

Additional details and impacted files 
@@             Coverage Diff             @@
##           dev/1.4    #2466      +/-   ##
===========================================
+<
8000
/span> Coverage    67.91%   68.31%   +0.39%     
===========================================
  Files          908      908              
  Lines        94505    94510       +5     
  Branches      7937     7936       -1     
===========================================
+ Hits         64187    64562     +375     
+ Misses       30068    29698     -370     
  Partials       250      250
Flag Coverage Δ
unittests 68.31% <100.00%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coderabbitai[bot]
coderabbitai bot reviewed Dec 16, 2024
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/core/src/mesh/SkinnedMeshRenderer.ts (1)

208-213: Consider adding unit tests for new conditional logic

With the introduction of the conditional branch based on rootBone, it's important to add or update unit tests to cover both scenarios:

  • When rootBone is present.
  • When rootBone is absent.

This will help ensure that the new logic behaves as expected in all cases and prevent potential regressions in the future.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a31440 and 8872bbd.

📒 Files selected for processing (1)
  • packages/core/src/mesh/SkinnedMeshRenderer.ts (1 hunks)
🔇 Additional comments (1)
packages/core/src/mesh/SkinnedMeshRenderer.ts (1)

208-213: Conditional handling in _updateBounds enhances robustness

The addition of the conditional check for rootBone in the _updateBounds method improves the control flow by appropriately handling cases where the skin may not have a rootBone. This ensures that the bounding box transformation is only applied when a rootBone is present, enhancing the renderer's robustness.

@GuoLei1990 GuoLei1990 added the ignore for release ignore for release label Dec 17, 2024
@GuoLei1990 GuoLei1990 changed the title Fix e2e error Fix Transform e2e error Dec 17, 2024
@GuoLei1990 GuoLei1990 merged commit 4167e83 into galacean:dev/1.4 Dec 17, 2024
9 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

Assignees

@cptbtptpbcptdtptp cptbtptpbcptdtptp

Labels
Bug Something isn't working ignore for release ignore for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cptbtptpbcptdtptp @GuoLei1990
0