8000 Fix particle emit bug and afterimage bug by GuoLei1990 · Pull Request #2434 · galacean/engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix particle emit bug and afterimage bug #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix particle emit bug and afterimage bug #2434

merged 1 commit into from
Nov 13, 2024

Conversation

GuoLei1990
Copy link
Member
@GuoLei1990 GuoLei1990 commented Nov 13, 2024 •
edited by coderabbitai bot
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Summary by CodeRabbit

  • New Features

    • Enhanced particle emission logic for improved control over particle generation.
    • Optimized rendering process by preventing unnecessary operations when no particles are alive.

  • Bug Fixes

    • Improved bounds update logic to maintain correct rendering behavior even when no particles are present.

@GuoLei1990 GuoLei1990 added Bug Something isn't working particle labels Nov 13, 2024
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Nov 13, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on the ParticleGenerator and ParticleRenderer classes. In ParticleGenerator.ts, the logic for emitting and managing particles has been refined, particularly in the _emit and _update methods, to enhance particle management based on current states. In ParticleRenderer.ts, improvements have been made to the rendering process, including checks to prevent rendering when no particles are alive and refining bounds calculations. These updates aim to optimize performance and ensure correct behavior in various particle states.

Changes

File Change Summary
packages/core/src/particle/ParticleGenerator.ts Modified _emit method to refine particle emission logic; adjusted _update for better state handling and buffer resizing; minor adjustments to bounds handling.
packages/core/src/particle/ParticleRenderer.ts Added checks in _prepareRender to avoid rendering with no alive particles; refined bounds update logic; updated _update to skip shader updates when no active particles are present.

Possibly related PRs

  • Fix particle rotation bug #2423: The changes in the MainModule class regarding the handling of the _tempVector40 variable and the _updateShaderData method suggest a direct relationship to particle management, similar to the updates made in the ParticleGenerator class for particle state management and emission logic.

Suggested reviewers

  • zhuxudong
  • MrKou47

🐇 In the realm where particles play,
A generator finds a new way.
With bounds refined and checks in place,
The renderer dances with grace.
No more points where once were streams,
Just vibrant bursts of particle dreams! 🌟

Warning

Rate limit exceeded

@GuoLei1990 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 54 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2b89197 and 035dc12.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link
codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.27%. Comparing base (2b89197) to head (035dc12).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/particle/ParticleGenerator.ts 0.00% 2 Missing ⚠️
packages/core/src/particle/ParticleRenderer.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2434      +/-   ##
==========================================
- Coverage   69.41%   68.27%   -1.14%     
==========================================
  Files         524      524              
  Lines       27480    27483       +3     
  Branches     4111     4112       +1     
==========================================
- Hits        19075    18765     -310     
- Misses       6900     7254     +354     
+ Partials     1505     1464      -41
Flag Coverage Δ
unittests 68.27% <25.00%> (-1.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 merged commit 94b0332 into galacean:main Nov 13, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Something isn't working particle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GuoLei1990
0