8000 Fix sort of compiled glsl source by Sway007 · Pull Request #1987 · galacean/engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix sort of compiled glsl source #1987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 25, 2024
Merged

Fix sort of compiled glsl source #1987

merged 7 commits into from
Jan 25, 2024

Conversation

Sway007
Copy link
Member
@Sway007 Sway007 commented Jan 24, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

sort compiled glsl position by index instead of line.

@Sway007 Sway007 added bug Something isn't working shader Shader related functions high priority High priority issue labels Jan 24, 2024
@Sway007 Sway007 added this to the 1.2 milestone Jan 24, 2024
@Sway007 Sway007 requested a review from GuoLei1990 January 24, 2024 13:29
@Sway007 Sway007 self-assigned this Jan 24, 2024
@GuoLei1990 GuoLei1990 merged commit b5b4e92 into galacean:dev/1.2 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 approved these changes

Assignees

@Sway007 Sway007

Labels
bug Something isn't working high priority High priority issue shader Shader related functions
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Sway007 @GuoLei1990
0